I hope this is solid and gets checked in!

Thanks for all the hard work!

I have it up on PEQ and no major problems so far. The only issue it seems is the AE part of the spell isn't working. It's single target only, even though the spell effect is supposed to be AE. This is using the level 5 harmony spell Druids get.

Everything else is perfect so far, thanks :)

Oh jeez yeah i forgot to check that. I'll have a look now.

Cheers

Bolly

Nice fix, thanks!
This is real important for players you like to play alone, or actually pull mobs like they do on live.

the bard and druid in our merry band i'm sure will put this code modifcation thorugh the ringer. i'll post any wierdnesses or issues as i find them. much thanks to all who put this fix together.

== sfisque

ps: you might want to include the cvs version info when you diff, so that people who are patching from older versions (like myself) are forewarned that they might have to do the modifications by hand or at least massage them a bit.

So what happened with this fix going into the official source? This is a good fix, and needs to be introduced.

Did anyone ever figure out a good way to make this work with AE lulls?

Dax

Alliance
 

I think that the same problem behind the lull and harmony line is also behind the problems I have seen with the Enchanter Alliance spell.

When cast, it produces instant aggro from the target.

Something to add to the check list.

The same basic fix also works for the Alliance line of spells (and bard song).
I'm new at this and haven't tested it extensively, but it seems to have things working the way they should.

In IsHarmonySpell(), spdat.cpp line ~202 replace:

if(sp.effectid[i] == SE_Lull || sp.effectid[i] == SE_Harmony)


with:

if(sp.effectid[i] == SE_Lull || sp.effectid[i] == SE_Harmony || sp.effectid[i] == SE_AddFaction)

Still having this issue - is this in the current one?

Could you be more specific? What problem are you having?

A successful harmony causes aggro

Just to make 100% certain, are you using the spell "Harmony" (id 250) or another spell with this effect?

yep, try it without gm mode on

hmm its working, i think it might have been related to body type - i'll check sorry about this!