EQEmulator Forums

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)
-   Development::GeorgeS's Tools (https://www.eqemulator.org/forums/forumdisplay.php?f=674)
-   -   NPC and loot editor - update2 (https://www.eqemulator.org/forums/showthread.php?t=24741)

GeorgeS 09-06-2008 03:41 PM

Ok, spent a few minutes updating the program to include these features and other's where possible.

NPC and Loot Editor
08.21.03 - Added ability to Backup and Restore Bots (including all inventory, and associated tables) - good if you rebuild your database.
Weapon & Shield Models- now fully integrated with the NPC & Loot editor - finally!!! - (under tools menu)
Added feature to add weapon/shield graphics to NPC's - This is in table fields called "Pri. Weapon Model" and "Sec. Weapon Model"
- Simply type in the new number and a graphic of the item will show in the program!


--upadated

NPC and Loot Editor
08.21.04 - Added a item stat viewer - Under menu item 'Special/show item stats'. You can view your npc's items and also in the new search item window!

I hope you like the item stat viewer, cause it was worth the 500 lines of code to implement it :)
The item search has also an advanced button where you can specifiy database like subqueries to pull out custom items
Clicking on an item in the grid will also show the selected item's stats if the item stat window is on.

http://66.159.225.58/eqemu/screen1.jpg

http://66.159.225.58/eqemu/screen2.jpg

GeorgeS

ChaosSlayer 09-07-2008 04:35 AM

NICE =)


BTW George, returning to our old discussion abotu quick copy button.
I thought you agreed with me =)

http://www.eqemulator.net/forums/sho...highlight=copy

Quote:

ChaosSlayer


honestly George, the new way of copying SIGNLE npc is a pain.

I have to:

click the file menu on the tab
select the proper sub menu
type in beging range
type in closign range
click Use this range
clicky copy

VS
old way of:

click copy
type in id

how about this, when COPY on main pannel is clicked a WINDOW will open and ask:

1) multyple npc copies- type in how many (with range in mind)
2) single npc copy - type in range

thought again a Single Copy button on main panel will hardly clutter the interface =)

Quote:

Actually that method does sound better than whats there now. Thanks for showing your workflow - I'll prioritise it now.

GeorgeS

GeorgeS 09-07-2008 01:32 PM

Ok, got around to adding the copy code as requested.
The copy tool has been ravamped. Final version has been updated as per request in the last build.

http://66.159.225.58/eqemu/screen3.jpg

GeorgeS

trevius 09-07-2008 05:01 PM

GeorgeS, you are a machine!

Just when I think the tools are pretty much complete, you add in stuff to make them even better than I could have expected!

The new weapon model viewer feature is awesome. Though, if possible, it might be nice if you could click on an image to view the larger version of the image. Also, a previous page button might be handy to go back a page. The newest version of the model viewer is really nice for quick references though and definitely an improvement over the previous model viewer :)

If I could ever get into the gaming industry, I would definitely recommend you for tool designs lol. If you can do this in your free time, I can't even imagine what you could do if you were paid full time to do it :)

GeorgeS 09-08-2008 01:45 AM

Thanks for the great review. I had considered going into the gaming industry, but I have a great career now, and programing is a hobby. I have improved my vb programing skills significantly over the last years, and still make the occasional game here and there. RPG gaming is my cup of tea, and for those interested, here's an interview I did for RPGdot a while back..

http://ultima.rpgdot.com/index.php?h...n=10053&ID=903

GeorgeS

trevius 09-09-2008 08:11 AM

Nice interview :)

BTW, I just noticed that if you scroll all of the way to the right with the current version of the editor, it looks like some of the fields aren't lined up properly. The accuracy and attack rating fields aren't even populating at all. My guess is when you added the new Primary and Secondary model fields, it caused the others to miss-align at some point.

MNWatchdog 09-09-2008 08:30 AM

Quote:

Originally Posted by GeorgeS (Post 155450)
Thanks for the great review. I had considered going into the gaming industry, but I have a great career now, and programing is a hobby. I have improved my vb programing skills significantly over the last years, and still make the occasional game here and there. RPG gaming is my cup of tea, and for those interested, here's an interview I did for RPGdot a while back..

http://ultima.rpgdot.com/index.php?h...n=10053&ID=903

GeorgeS

When I tried checking out your interview I got this web page: http://safebrowsing.clients.google.c...n=10053&ID=903

Jibbatwinkers 09-10-2008 06:15 PM

Ive run into a problem with the NPC/Loot Editor but I think it as to do with MySQL more than anything.

All of the other tools run great, the NPC/Loot Editor will launch fine, I can search through zones and even click and edit NPCs but if I click any NPC with a loot table ID it gives me this message:
Code:

Run-time error '-2147467259 (80004005)':

Data provider or other service returned an E_FAIL status.

The problem started yesterday after I updated to 1129 and put in these two queries:

Code:

CREATE TABLE `blocked_spells` (
  `id` int(11) NOT NULL auto_increment,
  `spellid` mediumint(8) unsigned NOT NULL default '0',
  `type` tinyint(4) NOT NULL default '0',
  `zoneid` int(4) NOT NULL default '0',
  `x` float NOT NULL default '0',
  `y` float NOT NULL default '0',
  `z` float NOT NULL default '0',
  `x_diff` float NOT NULL default '0',
  `y_diff` float NOT NULL default '0',
  `z_diff` float NOT NULL default '0',
  `message` varchar(255) NOT NULL default 'You cannot cast that spell here',
  `description` varchar(255) default NULL,
  PRIMARY KEY  (`id`)
)

Code:

Required SQL (Your groups will break completely without this):
CREATE TABLE `group_id` (
  `groupid` int(4) NOT NULL,
  `charid` int(4) NOT NULL,
  `name` varchar(64) NOT NULL,
  PRIMARY KEY (`groupid`, `charid`)
)

I removed the two tables and still have the same error. I googled the error and found some references to bad date fields but as far as I know dates are not stored in anything related to NPCs. I repaired my entire database and I also updated ODBC drivers.

Thanks for all your help, hopefully I provided enough information to get the editor up and running for me again. I'll keep looking for an answer and post if I find anything.

GeorgeS 09-11-2008 10:13 AM

Quote:

Originally Posted by trevius (Post 155494)
Nice interview :)

BTW, I just noticed that if you scroll all of the way to the right with the current version of the editor, it looks like some of the fields aren't lined up properly. The accuracy and attack rating fields aren't even populating at all. My guess is when you added the new Primary and Secondary model fields, it caused the others to miss-align at some point.

Make sure you're using the latest version. I fixed that bug a few minutes after seeing that myself.
Thanks
GeorgeS

GeorgeS 09-11-2008 09:51 PM

Jibbatwinkers

This kind of errors appear for more than one reason.
One of the reasons - if you have a table with fields that are "NOT NULL" but field has null values in it. (Other reason is a date/time field with all "0's".)

You mentioned it happens when you click on a column/field that = loottable_id, and crashes when there's no loottable_id there?

Then that must be a Null where it should'nt. I would check the table first.

GeorgeS

trevius 09-12-2008 03:26 AM

I know with version 1129 of the emu, I had problems caused by the blocked spells table. For some reason I had null entries in it and it was working until I updated to 1129. After that, the zone it was being used in wouldn't even boot up. So, that might be one issue.

Another idea for any problems with GeorgeS tools is to make sure to run the register_ocx.bat after every update. Sometimes you need them and sometimes you don't, but it never hurts to run it anyway :)

Oh, and just finally noticed that it looks like GeorgeS signed up for dyndns :) No wonder I couldn't get to your old site :P

trevius 09-12-2008 04:34 AM

It looks like the links for downloads need to be updated to work with dyndns. I tried the link from your page to download the NPC Loot Editor and it tried to send me to your old IP again. I used the same link that it tried to send me to and I put the dyndns name in there and it worked for the download.

trevius 09-13-2008 10:02 AM

Another minor note: Apparently when you select ALL for slots on the new edit, it sets it for none.

GeorgeS 09-13-2008 01:14 PM

Thanks for the report - New version should now support the proper Slot= "ALL" bit mask.


GeorgeS

ChaosSlayer 09-30-2008 09:28 PM

George, a small request.

With latest version of NPC Editor I noticed that 2 little buttons to add items into loot table have been moved all way to the right- and for some of us this is way outside of screen resolution area.

Coudl you perhaps move them in bewteen the 2 loot boxes? Or mayby on top of the loot box? Or perhaps make so I can use a Hot Key comob (like Alt+L) to simulate those buttons been pressed to add an item and Alt+R to remove selected item?

thank you much =)

GeorgeS 10-03-2008 10:44 PM

as requested, changed the key +/- layout so smaller screens can be used. Hope it helps. Dl the newest version.

GeorgeS

ChaosSlayer 10-03-2008 11:23 PM

thank you George =)

trevius 10-05-2008 05:24 PM

Hey GeorgeS, if you get the time, could you possibly change the loot table default for the equiped field to be NO instead of YES?

I think in most cases people would want them to be set to no and the only time they might want an item to be equiped would be if it is a weapon that they want to show the NPC as wielding. Even then, we can use the primary and secondary model settings to set that, so I think a default of NO would be best.

ChaosSlayer 10-05-2008 05:47 PM

Quote:

Originally Posted by trevius (Post 157743)
Hey GeorgeS, if you get the time, could you possibly change the loot table default for the equiped field to be NO instead of YES?

I think in most cases people would want them to be set to no and the only time they might want an item to be equiped would be if it is a weapon that they want to show the NPC as wielding. Even then, we can use the primary and secondary model settings to set that, so I think a default of NO would be best.

thats a debateable one =)

i do want the mob to equip any peace of weapon or armor they may have to make them tougher =)

on other hand wolf don't realy need to equp their pelts =)

so ist in fact 50/50 situation

trevius 10-05-2008 06:33 PM

I would say a large number of items in loot tables would cause a bag to show up in the NPC's hand if they are equiping it. NPCs can be set to get bonuses from weapons in the rules tables, but I don't think NPCs get bonuses from anything other than weapons if they are set to equiped in the loot tables. I would have to test it to make sure, but I bet that if you put a 1000 hp bracer on them and set it as equiped, it wouldn't actually effect the NPCs stats. I know for sure that even pet toys don't even fully work for giving stats to the pets. Some will add some stats, but certainly not all pet gear will have the effects that they should.

ChaosSlayer 10-05-2008 06:39 PM

well i guess you right, there are much fewer items that can "show up" on npc model than those that realy shouldn't (the "bags")

trevius 10-06-2008 09:16 AM

Oh, and it seems like the multiple slots for fingers still isn't working. The slot selected always says fingers in the tool, but it never actually lets you set both fingers, only 1 at a time. I would assume that the same might be true for bracers and earrings as well, but I haven't tested them yet.

GeorgeS 10-06-2008 10:31 PM

I checked in the DB and the values for these are

values in decimal

"Ears" = 18
"Wrists" = 1536
"Fingers" = 98304

Left Finger,2^16=65535
Right Finger,2^15=32768

So I added 65535+32768=98304, and thus all "ring" items are L/R finger by default.

So unless you need a left ring vs. a right ring, I would have to rewrite this.
The reason I did this is because in the database searching for %ring would return 98304 for all ring items, so I designed it based on that logic.
GeorgeS

GeorgeS 10-26-2008 01:32 AM

a minor update
 
NPC and Loot Editor
08.21.11 - Made grid editing more robust and you can now create new grids from empty zones. Minor features added throughout program

If you have a request for a feature then now's your chance to have it added!

GeorgeS

ChaosSlayer 10-26-2008 01:50 AM

Hiya George!

I do have small request, but not NPC editor related.

This is regards of Tradeskill editor

I was thinking if some sort of "Copy recepie" button could be implemented.
Which would take ENTIRE existing recepie and make a copy of it.

This would come handy when you need to make few dozens near identical recepies with lots of components which diffir by only a single component.
With a COPY ability, I would make bunch of copies and then only edit where nessesary

Another thing there- the section where you puting in custom container could use some work - atm I belive you need to type name of container, i much rather enter item ID# or even better have some sort of search/list window pop up.

Thanks =)

ChaosSlayer 10-29-2008 07:09 PM

Geroge, sudden of nothing I am getting "isbot now requred" error when trying to run NPC-loot editor
But my db has been updated a WHILE ago and allready has isbot, botinventory and botleader things.

Whats more important - I have allready this version before (of October 3rd)wihout any errors, so I am not sure where they coming from

I have donwloaded Oct 28 version and still geting same error

trevius 10-29-2008 09:06 PM

Did you run the register_ocx.bat again? You probably installed something else that broke your previous version's registration or something.

GeorgeS 10-29-2008 09:58 PM

Actually someone else had the same error. I think it's the query which checks for isbot field thay breaks the program on some computers. I have to dig further and find another way of running the query. Just give me a day to think it out..


/edit/

NPC and Loot Editor
08.21.13 - Changed the query that game players error that mentioned 'isbot' field is missing, despite having it in the table

Please download this version and see if it still gives that error.

GeorgeS

moydock 11-23-2008 06:18 AM

Hey George,
I downloaded the latest version and I'm still getting that error.
I updated my DB with the 2 tables and isbot column. All of your other editors that come with it work properly. Anyone else getting this?

GeorgeS 11-23-2008 12:16 PM

I'll remove the check - for some reason it does not work on all computers.
I think almost everyone uses bots now, so I'll use that as the default schema.

Look for an updated version later

*edit
Updated the program and it should no longer crash/give error there.

GeorgeS

moydock 11-24-2008 02:39 AM

Thanks, that worked. Great job on the additions btw. Going to try out the npc editor now!

trevius 12-23-2008 01:48 PM

GeorgeS,

One of the latest changes from KLS removed the timeleft field in the spawn2 table. This causes the spawn editor to break when it tries to load because it can't find that field anymore. KLS moved spawn timers to their own table now. Here is the required SQL for what she changed.

Required SQL:
Code:

DROP TABLE IF EXISTS `respawn_times`;
CREATE TABLE `respawn_times` (
  `id` int(11) NOT NULL default '0',
  `start` int(11) NOT NULL default '0',
  `duration` int(11) NOT NULL default '0',
  PRIMARY KEY  (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

ALTER TABLE `spawn2` DROP `timeleft`;

So, the tool needs to be updated to work with this new system. For anyone else seeing this problem, you should be able to add the timeleft field back to the spawn2 table for now until the tool is updated. That should at least let the tool work, but that field of the tool will be useless.

derekj54 12-23-2008 03:19 PM

yeah im having trouble with it, i click on a mob and go to create lootdrop and it says please select a mob, i go to create loottable and it crashes, i can edit mobs easily but the loot table part isnt working, i gotta do loot straight in the db for now /cry

GeorgeS 12-23-2008 09:00 PM

Thanks for the tip - I'll have a fix wed. asap

GeorgeS

GeorgeS 12-24-2008 12:04 PM

As promised,
NPC and Loot Editor
08.21.15 - Removed 'timeleft' field from spawn2 as required by the emu source. Errors are likely if you have not updated your database schema


Derekj54 - not sure about the error. No one else has this as a reported issue.
The loot code is same since several years ago.

Hope it fixes things.

GeorgeS

derekj54 12-25-2008 07:24 AM

its still doing it, i get a error: 94, invalid use of null. it happens when i try to create a table or if i use the repair loot tables option.

GeorgeS 12-26-2008 05:41 AM

Your error has to do with a null being in a table where it should not exist. You have to find this problem with a table editor. My program works fine.

GeorgeS

GeorgeS 02-25-2009 11:29 AM

Roambox editing is here!

Modified the spawngroup editor in the npc&loot program so that roambox data are visible and editable. If you have features you want in then let me know.


NPC and Loot Editor

08.21.18 - roamboxes supported


GeorgeS

Randymarsh9 06-29-2009 01:36 PM

I keep getting Run time error 9 subscript out of range. when I try to create an NPC

GeorgeS 06-29-2009 10:49 PM

Can you go thru exactly what type of npc and what class/race etc.. that gave that error?


-edit
I found the problem - some newer schemas use >64 fields in the npc_types table and the array would crash it.
Fixed in the newest version

Thanks
GeorgeS


All times are GMT -4. The time now is 01:16 PM.

Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.