Bard Bot Bug
 

Bard bots only play one song now. Niv's Harmonic.

Tested with GM account and player account. This changed after last update.

Created new bots and used ones I already had. Also used different race/combos. They do the same spell in combat and out of combat.

I haven't changed anything with that since it was working...

But, I will take a look as soon as I can :)

What level is your test?

I only tested with level 70.

I tested last night at level 70 with my main (monk) and a bard bot.

All songs were correctly cast depending on out-of-combat/pre-combat/in-combat mode.


You were having issues with the server boot-up process before, right? (circular updating)


I can post a few queries for you to test with to make sure your bard songs are the correct ones.

OK thanks! Yes, I had circular updating. That's gone now though.

Bear with me...


This is where we assign the npc_spell_id: https://github.com/EQEmu/Server/blob...e/bot.cpp#L487

And running..
..should return one entry - 'Bard Bot'

Conversely, running..
..should return one entry - '3008'


Checking the saved bot entries..
..should return zero (0) entries.


Finally, check the spell entries tables with..
..returning zero entries and..
returning 132 entries.


If these queries don't produce the expected results, don't delete anything and we'll go from there.

MariaDB [peq]> SELECT `name` FROM `npc_spells` WHERE `id` = '3008';
+----------+
| name |
+----------+
| Bard Bot |
+----------+
1 row in set (0.00 sec)

MariaDB [peq]> SELECT `id` FROM `npc_spells` WHERE `name` = 'Bard Bot';
+------+
| id |
+------+
| 3008 |
+------+
1 row in set (0.00 sec)

MariaDB [peq]> SELECT `spells_id` FROM `bot_data` WHERE `spells_id` < '3001' OR `spells_id` > '3016';
Empty set (0.00 sec)

MariaDB [peq]> SELECT `npc_spells_id` FROM `bot_spells_entries` WHERE `npc_spells_id` < '3001' OR `npc_spells_id` > '3016';
Empty set (0.00 sec)

MariaDB [peq]> SELECT `npc_spells_id` FROM `bot_spells_entries` WHERE `npc_spells_id` = '3008';
+---------------+
| npc_spells_id |
+---------------+
| 3008 |
| 3008 |
<...>
| 3008 |
| 3008 |
+---------------+
2508 rows in set (0.00 sec)

MariaDB [peq]>

That last query was a mistake on my part..really should have been:
..you don't need to re-run that or post new results.


Since you have 2508 entries, rather than the 132 I expected, I think we can start there.

Taking 2508 and dividing by 132 - which gives 19 - I'd say that you have at least an 18-fold duplication problem.


Try running this and see what you get:
I have 1347 entries..but, I expect you to have 3723 entries.

In that case you just have an over-applied bard bot spells update. If you have more, then the other spells may be (somehow) over-updated as well.


Let me know and we can go from there.

Here are the new results...

Current database: peq

+----------+
| COUNT(*) |
+----------+
| 3723 |
+----------+
1 row in set (0.01 sec)

MariaDB [peq]>

Ok, gimme a few minutes here and I'll export my entries for that table so you can just re-insert them without any complicated update process..

Try this:

OK ran the commands. Thanks for helping with this! :)

Let me know if that solves the problem.

If not, we can dig some more.

Tested with a newly created Bard and it's still just doing the same spell. :(

And you're running a stock database otherwise?

MariaDB [peq]> SELECT * FROM `bot_spells_entries` WHERE `npc_spells_id` = '3008';
+------+---------------+---------+------------+----------+----------+----------+--------------+----------+---------------+
| id | npc_spells_id | spellid | type | minlevel | maxlevel | manacost | recast_delay | priority | resist_adjust |
+------+---------------+---------+------------+----------+----------+----------+--------------+----------+---------------+
| 4556 | 3008 | 0 | 4294901760 | 0 | 0 | -1 | -1 | 0 | NULL |
| 4557 | 3008 | 704 | 1 | 12 | 54 | -1 | -1 | 1 | NULL |
| 4558 | 3008 | 1747 | 1 | 55 | 127 | -1 | -1 | 1 | NULL |
| 4559 | 3008 | 1749 | 16 | 60 | 127 | -1 | -1 | 1 | NULL |
| 4560 | 3008 | 743 | 256 | 38 | 64 | -1 | -1 | 1 | NULL |
| 4561 | 3008 | 3367 | 256 | 65 | 69 | -1 | -1 | 1 | NULL |
| 4562 | 3008 | 5385 | 256 | 70 | 79 | -1 | -1 | 1 | NULL |
| 4563 | 3008 | 14074 | 256 | 80 | 84 | -1 | -1 | 1 | NULL |
| 4564 | 3008 | 18059 | 256 | 85 | 89 | -1 | -1 | 1 | NULL |
| 4565 | 3008 | 26084 | 256 | 90 | 94 | -1 | -1 | 1 | NULL |
| 4566 | 3008 | 29182 | 256 | 95 | 127 | -1 | -1 | 1 | NULL |
| 4567 | 3008 | 3566 | 256 | 50 | 62 | -1 | -1 | 2 | NULL |
| 4568 | 3008 | 3370 | 256 | 63 | 67 | -1 | -1 | 2 | NULL |
| 4569 | 3008 | 5378 | 256 | 68 | 77 | -1 | -1 | 2 | NULL |
| 4570 | 3008 | 14071 | 256 | 78 | 82 | -1 | -1 | 2 | NULL |
| 4571 | 3008 | 18056 | 256 | 83 | 87 | -1 | -1 | 2 | NULL |
| 4572 | 3008 | 26033 | 256 | 88 | 92 | -1 | -1 | 2 | NULL |
| 4573 | 3008 | 29128 | 256 | 93 | 127 | -1 | -1 | 2 | NULL |
| 4574 | 3008 | 744 | 256 | 46 | 62 | -1 | -1 | 3 | NULL |
| 4575 | 3008 | 3373 | 256 | 63 | 66 | -1 | -1 | 3 | NULL |
| 4576 | 3008 | 5379 | 256 | 67 | 76 | -1 | -1 | 3 | NULL |
| 4577 | 3008 | 14068 | 256 | 77 | 81 | -1 | -1 | 3 | NULL |
| 4578 | 3008 | 18053 | 256 | 82 | 86 | -1 | -1 | 3 | NULL |
| 4579 | 3008 | 26003 | 256 | 87 | 91 | -1 | -1 | 3 | NULL |
| 4580 | 3008 | 29101 | 256 | 92 | 127 | -1 | -1 | 3 | NULL |
| 4581 | 3008 | 3567 | 256 | 42 | 60 | -1 | -1 | 4 | NULL |
| 4582 | 3008 | 3363 | 256 | 61 | 65 | -1 | -1 | 4 | NULL |
| 4583 | 3008 | 5371 | 256 | 66 | 75 | -1 | -1 | 4 | NULL |
| 4584 | 3008 | 14065 | 256 | 76 | 80 | -1 | -1 | 4 | NULL |
| 4585 | 3008 | 18050 | 256 | 81 | 85 | -1 | -1 | 4 | NULL |
| 4586 | 3008 | 25976 | 256 | 86 | 90 | -1 | -1 | 4 | NULL |
| 4587 | 3008 | 29077 | 256 | 91 | 127 | -1 | -1 | 4 | NULL |
| 4588 | 3008 | 707 | 256 | 30 | 59 | -1 | -1 | 5 | NULL |
| 4589 | 3008 | 4210 | 256 | 60 | 127 | -1 | -1 | 5 | NULL |
| 4590 | 3008 | 738 | 8192 | 23 | 50 | -1 | -1 | 1 | NULL |
| 4591 | 3008 | 1751 | 8192 | 51 | 59 | -1 | -1 | 1 | NULL |
| 4592 | 3008 | 1748 | 8192 | 60 | 63 | -1 | -1 | 1 | NULL |
| 4593 | 3008 | 3066 | 8192 | 64 | 127 | -1 | -1 | 1 | NULL |
| 4594 | 3008 | 738 | 8192 | 51 | 63 | -1 | -1 | 2 | NULL |
| 4595 | 3008 | 1751 | 8192 | 64 | 127 | -1 | -1 | 2 | NULL |
| 4596 | 3008 | 738 | 8192 | 64 | 127 | -1 | -1 | 3 | NULL |
| 4597 | 3008 | 3682 | 32768 | 45 | 85 | -1 | -1 | 1 | NULL |
| 4598 | 3008 | 25958 | 32768 | 86 | 90 | -1 | -1 | 1 | NULL |
| 4599 | 3008 | 29059 | 32768 | 91 | 127 | -1 | -1 | 1 | NULL |
| 4600 | 3008 | 3681 | 32768 | 52 | 127 | -1 | -1 | 2 | NULL |
| 4601 | 3008 | 10448 | 32768 | 74 | 78 | -1 | -1 | 3 | NULL |
| 4602 | 3008 | 14029 | 32768 | 79 | 83 | -1 | -1 | 3 | NULL |
| 4603 | 3008 | 18023 | 32768 | 84 | 127 | -1 | -1 | 3 | NULL |
| 4604 | 3008 | 1754 | 131072 | 53 | 127 | -1 | -1 | 1 | NULL |
| 4605 | 3008 | 10436 | 131072 | 73 | 127 | -1 | -1 | 2 | NULL |
| 4606 | 3008 | 2606 | 262144 | 52 | 59 | -1 | -1 | 1 | NULL |
| 4607 | 3008 | 2610 | 262144 | 60 | 127 | -1 | -1 | 1 | NULL |
| 4608 | 3008 | 700 | 262144 | 1 | 9 | -1 | -1 | 2 | NULL |
| 4609 | 3008 | 701 | 262144 | 10 | 35 | -1 | -1 | 2 | NULL |
| 4610 | 3008 | 740 | 262144 | 36 | 41 | -1 | -1 | 2 | NULL |
| 4611 | 3008 | 702 | 262144 | 42 | 49 | -1 | -1 | 2 | NULL |
| 4612 | 3008 | 747 | 262144 | 50 | 61 | -1 | -1 | 2 | NULL |
| 4613 | 3008 | 3374 | 262144 | 62 | 64 | -1 | -1 | 2 | NULL |
| 4614 | 3008 | 4871 | 262144 | 65 | 67 | -1 | -1 | 2 | NULL |
| 4615 | 3008 | 5376 | 262144 | 68 | 78 | -1 | -1 | 2 | NULL |
| 4616 | 3008 | 14080 | 262144 | 79 | 83 | -1 | -1 | 2 | NULL |
| 4617 | 3008 | 18065 | 262144 | 84 | 88 | -1 | -1 | 2 | NULL |
| 4618 | 3008 | 26042 | 262144 | 89 | 93 | -1 | -1 | 2 | NULL |
| 4619 | 3008 | 29143 | 262144 | 94 | 127 | -1 | -1 | 2 | NULL |
| 4620 | 3008 | 7 | 262144 | 6 | 19 | -1 | -1 | 2 | NULL |
| 4621 | 3008 | 1287 | 262144 | 20 | 31 | -1 | -1 | 3 | NULL |
| 4622 | 3008 | 723 | 262144 | 32 | 33 | -1 | -1 | 3 | NULL |
| 4623 | 3008 | 1448 | 262144 | 34 | 54 | -1 | -1 | 3 | NULL |
| 4624 | 3008 | 1759 | 262144 | 55 | 61 | -1 | -1 | 3 | NULL |
| 4625 | 3008 | 3651 | 262144 | 62 | 66 | -1 | -1 | 3 | NULL |
| 4626 | 3008 | 5377 | 262144 | 67 | 70 | -1 | -1 | 3 | NULL |
| 4627 | 3008 | 10421 | 262144 | 71 | 75 | -1 | -1 | 3 | NULL |
| 4628 | 3008 | 14008 | 262144 | 76 | 80 | -1 | -1 | 3 | NULL |
| 4629 | 3008 | 18008 | 262144 | 81 | 87 | -1 | -1 | 3 | NULL |
| 4630 | 3008 | 26015 | 262144 | 88 | 92 | -1 | -1 | 3 | NULL |
| 4631 | 3008 | 29107 | 262144 | 93 | 127 | -1 | -1 | 3 | NULL |
| 4632 | 3008 | 734 | 262144 | 7 | 8 | -1 | -1 | 4 | NULL |
| 4633 | 3008 | 710 | 262144 | 9 | 12 | -1 | -1 | 4 | NULL |
| 4634 | 3008 | 711 | 262144 | 13 | 16 | -1 | -1 | 4 | NULL |
| 4635 | 3008 | 709 | 262144 | 17 | 40 | -1 | -1 | 4 | NULL |
| 4636 | 3008 | 714 | 262144 | 41 | 46 | -1 | -1 | 4 | NULL |
| 4637 | 3008 | 748 | 262144 | 47 | 57 | -1 | -1 | 4 | NULL |
| 4638 | 3008 | 1763 | 262144 | 58 | 72 | -1 | -1 | 4 | NULL |
| 4639 | 3008 | 11881 | 262144 | 73 | 77 | -1 | -1 | 4 | NULL |
| 4640 | 3008 | 14056 | 262144 | 78 | 82 | -1 | -1 | 4 | NULL |
| 4641 | 3008 | 18041 | 262144 | 83 | 87 | -1 | -1 | 4 | NULL |
| 4642 | 3008 | 26027 | 262144 | 88 | 92 | -1 | -1 | 4 | NULL |
| 4643 | 3008 | 29122 | 262144 | 93 | 127 | -1 | -1 | 4 | NULL |
| 4644 | 3008 | 734 | 262144 | 9 | 24 | -1 | -1 | 5 | NULL |
| 4645 | 3008 | 712 | 262144 | 25 | 28 | -1 | -1 | 5 | NULL |
| 4646 | 3008 | 715 | 262144 | 29 | 32 | -1 | -1 | 5 | NULL |
| 4647 | 3008 | 713 | 262144 | 33 | 36 | -1 | -1 | 5 | NULL |
| 4648 | 3008 | 716 | 262144 | 37 | 44 | -1 | -1 | 5 | NULL |
| 4649 | 3008 | 4083 | 262144 | 45 | 52 | -1 | -1 | 5 | NULL |
| 4650 | 3008 | 4084 | 262144 | 53 | 63 | -1 | -1 | 5 | NULL |
| 4651 | 3008 | 3362 | 262144 | 64 | 64 | -1 | -1 | 5 | NULL |
| 4652 | 3008 | 4872 | 262144 | 65 | 68 | -1 | -1 | 5 | NULL |
| 4653 | 3008 | 5382 | 262144 | 69 | 75 | -1 | -1 | 5 | NULL |
| 4654 | 3008 | 14062 | 262144 | 76 | 80 | -1 | -1 | 5 | NULL |
| 4655 | 3008 | 18047 | 262144 | 81 | 85 | -1 | -1 | 5 | NULL |
| 4656 | 3008 | 25961 | 262144 | 86 | 90 | -1 | -1 | 5 | NULL |
| 4657 | 3008 | 29062 | 262144 | 91 | 127 | -1 | -1 | 5 | NULL |
| 4658 | 3008 | 734 | 262144 | 25 | 43 | -1 | -1 | 6 | NULL |
| 4659 | 3008 | 4085 | 262144 | 44 | 51 | -1 | -1 | 6 | NULL |
| 4660 | 3008 | 4086 | 262144 | 52 | 62 | -1 | -1 | 6 | NULL |
| 4661 | 3008 | 4087 | 262144 | 63 | 68 | -1 | -1 | 6 | NULL |
| 4662 | 3008 | 5374 | 262144 | 69 | 71 | -1 | -1 | 6 | NULL |
| 4663 | 3008 | 10439 | 262144 | 72 | 76 | -1 | -1 | 6 | NULL |
| 4664 | 3008 | 14020 | 262144 | 77 | 81 | -1 | -1 | 6 | NULL |
| 4665 | 3008 | 18014 | 262144 | 82 | 86 | -1 | -1 | 6 | NULL |
| 4666 | 3008 | 25991 | 262144 | 87 | 127 | -1 | -1 | 6 | NULL |
| 4667 | 3008 | 734 | 262144 | 30 | 82 | -1 | -1 | 7 | NULL |
| 4668 | 3008 | 18020 | 262144 | 83 | 127 | -1 | -1 | 7 | NULL |
| 4669 | 3008 | 734 | 262144 | 83 | 127 | -1 | -1 | 8 | NULL |
| 4670 | 3008 | 2603 | 262144 | 30 | 127 | -1 | -1 | 9 | NULL |
| 4671 | 3008 | 7 | 524288 | 6 | 19 | -1 | -1 | 1 | NULL |
| 4672 | 3008 | 1287 | 524288 | 20 | 31 | -1 | -1 | 1 | NULL |
| 4673 | 3008 | 723 | 524288 | 32 | 33 | -1 | -1 | 1 | NULL |
| 4674 | 3008 | 1448 | 524288 | 34 | 54 | -1 | -1 | 1 | NULL |
| 4675 | 3008 | 1759 | 524288 | 55 | 61 | -1 | -1 | 1 | NULL |
| 4676 | 3008 | 3651 | 524288 | 62 | 66 | -1 | -1 | 1 | NULL |
| 4677 | 3008 | 5377 | 524288 | 67 | 70 | -1 | -1 | 1 | NULL |
| 4678 | 3008 | 10421 | 524288 | 71 | 75 | -1 | -1 | 1 | NULL |
| 4679 | 3008 | 14008 | 524288 | 76 | 80 | -1 | -1 | 1 | NULL |
| 4680 | 3008 | 18008 | 524288 | 81 | 87 | -1 | -1 | 1 | NULL |
| 4681 | 3008 | 26015 | 524288 | 88 | 92 | -1 | -1 | 1 | NULL |
| 4682 | 3008 | 29107 | 524288 | 93 | 127 | -1 | -1 | 1 | NULL |
| 4683 | 3008 | 717 | 524288 | 5 | 29 | -1 | -1 | 2 | NULL |
| 4684 | 3008 | 2603 | 524288 | 30 | 127 | -1 | -1 | 2 | NULL |
| 4685 | 3008 | 717 | 524288 | 30 | 48 | -1 | -1 | 3 | NULL |
| 4686 | 3008 | 2605 | 524288 | 49 | 127 | -1 | -1 | 3 | NULL |
| 4687 | 3008 | 2602 | 524288 | 15 | 127 | -1 | -1 | 4 | NULL |
+------+---------------+---------+------------+----------+----------+----------+--------------+----------+---------------+
132 rows in set (0.00 sec)

MariaDB [peq]>

Yes I have not changed anything from the standard Akk install database

Just for clarification..

There are 3 casting modes for bots now:

Out-of-Combat: Non-combat with no target or non-attackable target selected.


Pre-Combat: Non-combat with attackable target selected.


In-Combat: Engaged combat.


Each condition will cause the bot to select a specific list of spells to cast from. (Only bard bots have code that make use of this feature at this time.)


At level 70, I'm getting:

Out-of-Combat: `Cantata of Life,` `Song of Sustenance` and `Selo's Accelrating Chorus`

Pre-Combat: `War Song of the Vah Shir,` `War March of Muram,` `Cantata of Life,` `Verse of Vesagran,` `Niv's Harmonic` and `Eriki's Psalm of Power`

In-Combat: `War Song of the Vah Shir,` `War March of Muram,` `Cantata of Life,` `Verse of Vesagran,` `Niv's Harmonic` and `Eriki's Psalm of Power`

Awesome work Uleat!

This is what i'm getting:

At level 70, I'm getting:

Out-of-Combat: `Niv's Harmonic`

Pre-Combat: `Niv's Harmonic`

In-Combat: `Vulka's Chant of Frost`

I agree he does great work! I'm so glad we have someone working on Bots and improving them. :)

It'll be a little while because I have to back out of my current dev setup..but, let me recompile the bots binaries and push fresh ones.

And no problems with the other bots? (Aside from their old casting logic...)

The other bots seem to be working fine. I leveled up a character the past few days from 1-66 and had no problems. I have had others say that the cleric bot stops healing and they died, but I have not confirmed that and it could be one of my bosses that cast a stun or silence :(

I would say others are working fine. :)

Yeah, that cleric issue part of the old logic and spells that needs to be reviewed.


Ok..just updated the installer binaries for bots. Let me know if that does anything.

Just run Windows_server_download_bots from the Server Assets menu? or do i need to do anything else?

I tried rebooting the server but they didn't auto update so figured I need to do it manually.

Yes..pretty sure binaries are a manual thing.

I did actually test these binaries (I usually run in full debug mode) and they performed as expected.

Thank you so much for your help Uleat! I have out of combat, pre and in combat songs now. That fixed them :)

Whew! Scared me for a minute there..was running out of places to look :P


Also, on a side note, the stackable trading project was becoming way too complex to implement...

What I'll probably do is just do something for stack swapping rather than try to move partials.

That will give ranged fighters the ability to use those weapons again.