2 Trivial bugs fixed
Not sure this is the right place for these....
I was running World under Valgrind (memory leak checker) and found a couple of "trivial" bugs. common/linked_list.h Code:
template<class TYPE> Note that the destructor for this class checks that dont_delete is false, so this prevents it ever being called with an unitialised value. world/net.cpp in main(), from line 238: Code:
if (!zoneserver_list.worldclock.loadFile(EQTIME_INI)) It's actually pretty solid without this, but this improves the style... if anyone cares. These two fixes make Valgrind report no errors outside libc for world. |
nice, the linked list one will actually make a difference, I have seen that cause problems but never been able to track it down. Both changes have been made.
... now to get zone to run in valgrind, lol.... |
Quote:
Glad the list thing is useful though. I'll keep trying to identify more "defects" anyway. |
this has been evaluated a few times in the past, and seems to relate to valgrind's implementation of pthread mutexes.
but yea, 233Mhz will not cut it, it barily runs on a 3.2 Ghz machine without timing out. |
All times are GMT -4. The time now is 06:51 AM. |
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.