EQEmulator Forums - Bagtype 13 Combine Bug

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Development::Bug Reports (https://www.eqemulator.org/forums/forumdisplay.php?f=591)

- - Bagtype 13 Combine Bug (https://www.eqemulator.org/forums/showthread.php?t=22040)

Bagtype 13 Combine Bug

If this is already a know bug please delete this.

On both PEQ Server and EQEmu 0.7.0-934 with PEQ Luclin Database, it appears all bag's of bagtype = 13 will not combine their contents based on there recipes.

For example, #summonitem 17613. Combine #summonitem 7096 with #summonitem 29859 and you should get #summonitem 7000. But what you get is a message saying you can not combine in the bag I have.

I tried about 5 random selections of recipes from PEQ Luclin database and I haven't gotten one to combine yet.

FNW or KLS,

I need to test this still but I am at work and can not till I get home. I thought I would post this anyway in case you read this to get your input.

To let tradeskill containers perform a combine, I think all that needs to be added is the following:

./common/skills.h - add this line to the enum

Code:

TRADESKILL = 75

tradeskills.cpp - add this statement in Object::HandleCombine() method.

Code:

case 13: //Quest Containers

                tradeskill = TRADESKILL;

                break;

tradeskills.cpp - remove the statement that looks like the one below from Object::HandleCombine() method.

Code:

case 0x0D:

                tradeskill = POTTERY;

                break;

As I said, I still need to test this but I can't see why it won't work as I sit here and look at the code.

I tested this small change on my own development server and I can confirm it does work. Any chance we can put this into the server code? Thanks much and enjoy!