EQEmulator Forums - $faction bug fix

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Development::Server Code Submissions (https://www.eqemulator.org/forums/forumdisplay.php?f=669)

- - $faction bug fix (https://www.eqemulator.org/forums/showthread.php?t=29182)

$faction bug fix

currently this quest variable is passing client->GetID() instead of client->CharacterID(), which the function wants

not sure if this will cause problems with anything else so if it gets committed make sure you look for problems or something (I didn't find any)

Code:

Index: EQEmuServer/zone/embparser.cpp

===================================================================

--- EQEmuServer/zone/embparser.cpp        (revision 899)

+++ EQEmuServer/zone/embparser.cpp        (working copy)

@@ -368,7 +368,7 @@

 

                         // Need to figure out why one of these casts would fail..

                         if (client && npc) {

-                                fac = client->GetFactionLevel(client->GetID(), npcmob->GetID(), client->GetRace(), client->GetClass(), DEITY_AGNOSTIC, npc->GetPrimaryFaction(), npcmob);

+                                fac = client->GetFactionLevel(client->CharacterID(), npcmob->GetID(), client->GetRace(), client->GetClass(), DEITY_AGNOSTIC, npc->GetPrimaryFaction(), npcmob);

                         }

                         else if (!client) {

                                 LogFile->write(EQEMuLog::Status, "WARNING: cast failure on mob->CastToClient()");

The current faction code given does not take into account the character's choice of deity. I'm not sure why but in embparser.cpp its just using agnostic.

Code:

                                fac = client->GetFactionLevel(client->CharacterID(), npcmob->GetID(), client->GetRace(), client->GetClass(), DEITY_AGNOSTIC, npc->GetPrimaryFaction(), npcmob);

could be

Code:

                                fac = client->GetFactionLevel(client->CharacterID(), npcmob->GetID(), client->GetRace(), client->GetClass(), client->GetDeity(), npc->GetPrimaryFaction(), npcmob);

I ran into this issue when trying to write a quest where the NPC's primary faction is base -600 with +1000 for a certain deity. In the game the NPC cons correctly but the perl script always gives dubious.

-Nachyoz

Added the last change to revision 995.