EQEmulator Forums - COMMITTED: Random door issue fix

Was able to produce the error reliably on Windows 7(x64) with a 32-bit release build (debug build did not produce the error for me) using a GM account only. Since this appears to be a case of memory getting clobbered slightly before you would like, it may be hard to reproduce.

Log GM character out at a portal stone (I used qeynos and freeport.) Restart EQEMU server. Log back in. Use stone to port to PoK. All stones and teleporting doors in PoK no longer function. Problem appears to be fixed by the following.

Code:

Index: zone/doors.cpp

===================================================================

--- zone/doors.cpp        (revision 1004)

+++ zone/doors.cpp        (working copy)

@@ -384,11 +384,12 @@

         //and met all the reqs for opening

         //everything to do with closed doors has already been taken care of

         //we return because we don't want people using teleports on an unlocked door (exploit!)

-        safe_delete(outapp);

         if(md->action == CLOSE_DOOR)

         {

+                safe_delete(outapp);

                 return;

         }

+        safe_delete(outapp);

 

         if((GetTriggerDoorID() != 0) && (GetTriggerType() == 1))

         {