EQEmulator Forums - MitigateMeleeDamage Never Fading?

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Spell Support (https://www.eqemulator.org/forums/forumdisplay.php?f=664)

- - MitigateMeleeDamage Never Fading? (https://www.eqemulator.org/forums/showthread.php?t=35331)

Hateborne

05-13-2012 02:00 PM

MitigateMeleeDamage Never Fading?

Is there any known bug/problem with partial melee runes? I have an ability essentially copied from Panoply of Vie (mitigate 10% until 2080) that has Mitigate 15% until 50,000.

It never fades...

I let it run for ~20min, tanking several mobs, and it never faded. I kept the 15% melee mitigation and took ~400k damage but the ability never faded.

Now the best part is Panoply of Vie WILL fade, this copied spell with raised mana cost, mitigation percentage, and rune amount never does.

Any pointers? :-\

-Hate

lerxst2112

05-13-2012 06:38 PM

Code:

uint32 GetPartialMeleeRuneAmount(uint32 spell_id)

{

        for(int i = 0; i < EFFECT_COUNT; ++i)

        {

                if(spells[spell_id].effectid[i] == SE_MitigateMeleeDamage)

                {

                        return spells[spell_id].max[i];

                }

        }

        return 0;

}

The 3 minute guess. Can't fit 50k into a sint16 which is what max[i] is there. The return value is a uint32, and with sign extension the negative 16-bit value becomes a very large unsigned 32-bit value, somewhere around 4 billion.

Hateborne

05-13-2012 08:43 PM

Apologies for bothering again.

Thanks for info yet again lerxst2112!

-Hate

All times are GMT -4. The time now is 11:52 PM.