EQEmulator Forums - Damage Shield EXP fix

EQEmulator Forums (https://www.eqemulator.org/forums/index.php)

- Development::Server Code Submissions (https://www.eqemulator.org/forums/forumdisplay.php?f=669)

- - Damage Shield EXP fix (https://www.eqemulator.org/forums/showthread.php?t=35643)

demonstar55

08-12-2012 05:15 PM

COMMITTED: Damage Shield EXP fix

Currently the damage dealt via a damage shield factors into who gets experience. This is not how it functions on live.

Proof: http://www.magecompendium.com/pets-library.html#petexp and this post on Alla also mentions this fact in the "pincushioning" part http://everquest.allakhazam.com/foru...73098101489300

Code:

Index: attack.cpp

===================================================================

--- attack.cpp  (revision 2183)

+++ attack.cpp  (working copy)

@@ -3241,7 +3241,8 @@



        if(attacker){

                if(attacker->IsClient()){

-                       if(!attacker->CastToClient()->GetFeigned())

+                       // Damage shield damage shouldn't count towards who gets EXP

+                       if(!attacker->CastToClient()->GetFeigned() && !FromDamageShield)

                                AddToHateList(attacker, 0, damage, true, false, iBuffTic);

                }

                else

cavedude

09-10-2012 12:30 PM

This was added to PEQ with the AA timer fix and I forgot to mention it.

lerxst2112

09-10-2012 07:18 PM

That's gonna make people that are working on their RoA sad on EZ. Any chance of making it a rule to toggle the old behaviour on?

cavedude

09-10-2012 07:47 PM

Of course, just an extra 2 lines.

lerxst2112

09-10-2012 09:08 PM

I'm totally adding another gnome to my "Cavedude is the best!" shrine.

quido

02-03-2013 01:20 AM

Damageshield should still add hate though, right? The damage just shouldn't count towards exp.

demonstar55

02-03-2013 01:58 AM

No, and damage shields should cause no hate.

knowom

09-01-2013 05:58 AM

Quote:

Originally Posted by demonstar55 (Post 217522)

No, and damage shields should cause no hate.

Says who? :roll: I get the exp thing and the concern, but actually if a toggle could also be implemented to make damage shields cause hate that would be a interesting feature.

Especially if you could even categorize it further by damage shields from items and damage shields from spells and adjust the aggro generation amounts caused.

Additionally same could be said with reverse damage shield which has often had limited usage though that could have fantastic use for a custom Paladin class with like a custom reverse damage shield spell proc buff for example and or Bard class for song spells.

HeyJudd

09-01-2013 11:12 AM

This project is about recreating the EQ from Live, if you want crazy crap like that then edit the source yourself.

All times are GMT -4. The time now is 10:54 AM.