Perl Issue
 

I've been having some issues with a Perl script, and I don't know why, can anyone be of some help as there aren't many guide for Perl to my knowledge. Here's the issue, everything in sub EVENT_SAY works, but the item hand-ins don't work, please help. D: Thanks!

P.S. I don't know the appropriate section for this, would be great if you could help me with that if this isn't the correct section.

Just a quick glance as I don't have a lot of time, I see and extra close parenthesis in your event item (first line).

there are perl tutorials all over the place. it's been around since 1987 and isn't only used in the emulator.

here is the official 5.12.4 introduction.
here is a list of official, categorized 5.12.4 tutorials.

as to the problems with this script, you have an incorrectly placed closing bracket here:

additionally, you have two else statements in the same part of your logic chain at the bottom. you can only use one.

finally, you should be using if/elsif statements in your chains, not just if statements. elsif causes the script to stop looking for matches after it finds one. in your script's case, it will continue looking at each condition, even after a match is found.

example:

i missed that one. :)

also, you can run your scripts from the command line like this to help find syntax errors:

And take the return items out of the logic block that is the incorrect usage of it.

Okay, where you said that is the incorrect usage, it also shows up in Vanilla scripts such as Guard_Vyrinn.pl. I don't see any other way for me to return their items if they're not the correct level or it's not the correct item.

Edit: All the NPC does when I hand him items is eat them, he doesn't reset my level or anything. Here's the revised script.

As was suggested before, you have tools available to make sure your script is syntactically correct first before worring about whether the logic is correct.

There are 104 { characters, and 103 } characters. You can use the Notepad++ count feature to see this easily. I'll leave you to figure out where you have a mismatch.

When Sorvani says that it is incorrect usage - he means it is now incorrect. The plugin was changed recently, but all the quests that operated with this method have not yet been changed.

I took your advice, found the mistake, hopefully this is better, haven't tested it yet.

Now there are 105 { and 103 }. You're headed in the right direction for sure.

Actually, the return items check was always supposed to be outside of any if block by design. The items in the hash are removed by the check_handin if the logic passed to it is true.
So regardless of whether or not there is anything left in the hash, you call the return_items at the end of the EVENT_ITEM and it will appropriately return anything not used up.
The recent changes to this plugin do not affect this basic design. The recent changes were to let the plugin support the new multi-quest functionality built into the NPC's..

Edit: Post from 2009 on the subject: http://www.eqemulator.org/forums/sho...54&postcount=3

Basically all the vanilla quests are wrong. Granted for almost all basic quest logic there con ONLY be an if and else. But a lot of the quests will eat extra items because of this.

Here's the re-revised code, I put a plugin for the return items, and an if statement after, hope this is better. D:

Edit: I also added "my $roa = $item(150009);" because I wanted to test whether or not that was how to make an NPC link an item, I am fairly new to Perl, any help or feedback is greatly appreciated.

google "loop" for a brick shitting.

geez, open a command prompt and change to your quest directory. type perl -c filename.pl and fix what it says is broke... here i fixed it.

Here is the wiki to saylink.. search is that hard?

but that would be too easy