Quote:
Originally Posted by unknown405
Code:
--Bald players bug fixed.
Original code fix/inspiration by Kraeger
Update by KLS
|
Well, not to beat this into the ground, but I disagree on many points you make here. For one, the patch note you made isn't exactly accurate. Yes, Kraeger did make some code to fix it, but KLS didn't update his code to make the code that went into the source. She wrote her own from scratch. Again, he should get some kind of credit, but wording it correctly isn't easy since none of his code actually went into the source. So it would have to be more like:
Code:
KLS: Fix for bald characters hopefully (inspired by code from Kraeger).
Though, she has already said that her code still needs some work, so she will still need to add more to it to get it working perfectly. Maybe she can use some of what Kraeger has written to get hers working right. If so, then I am sure she will have his name in there, because it will rightfully deserve to be there.
Quote:
Originally Posted by unknown405
That seems the best way to me. I completely side with Kraeger here as an unbiased comment. I don't know KLS and I don't know Kraeger, I'm new to the project myself so I have no bias at all but to be honest I think Kraeger is in the right here for the most part.
|
I agree with this.
Quote:
Originally Posted by unknown405
KLS I am very new to this project and I know exactly who you are, as everyone else does. You don't need any more recognition then the load of it that you already have. Everyone knows who you are and the fact is this never would have been done without Kraeger (at least not anytime soon.)
|
Didn't you just say you don't know who she is in the previous paragraph? :P Trust me when I say that she didn't write the patch notes the way she did to get herself credit. I highly doubt she even cares much about it. Since the code she put in doesn't even work perfectly yet, it is probably better for Kraeger that his name wasn't on it, lol. Again, I agree that this would definitely not be in if Kraeger hadn't taken the initiative.
I have written some code (based on other code submissions) to allow admins to disable Call of the Hero on a Per Zone Basis. If someone completely rewrote the code so that it worked on a perimeter to disable spells, does that mean I should get any credit for it? Not in my opinion. Sure, maybe I posted code to get it to work one way, but if someone rewrote it, and that new code was put into the source, I wouldn't expect my name to be on it, nor care if it was.
Quote:
Originally Posted by unknown405
So I think the patch notes I put at the top of this post will make everyone happy. I would have reacted the same way as Kraeger, but the fact is not too many people read the patch notes. The only people that actually read the patch notes (for the most part) read the forums as well and know what the situation is and know who did what.
|
This almost sounds like you are suggesting some corruption in the Project. But, I assure you, there is not.
Quote:
Originally Posted by unknown405
So with that said, can you just do what I suggested to make everyone happy and then forget about this issue. KLS you may not understand, but people who are unknown (ironic I know) and have no reputation make these code fixes for the appreciation and recognition more than to fix the problem for the most part.
|
I disagree with this. I do everything I can here just to help out the project. Whether that is posting code, quests, wiki pages, or just answering questions and helping people to get things working. I could just as easily keep everything I do to myself, but that doesn't do anyone any good. It slows the progress of the project and it is just plain selfish IMO. Overall, this community is the most mature and helpful group that I have seen anywhere on the net. There is very limited drama and many many people are willing to help out as much as they can. I think most of us do it just to make the Emulator better. So, to say that people do it just for appreciation and recognition more than just to help out isn't true in many cases. I think most of us just do it to better the project. Any other reason is small and almost pointless.
Quote:
Originally Posted by unknown405
I don't know Kraeger, maybe he's helped before. But my point is that when someone spends their time fixing something and then sees it completely re-written with different credit given it's a horrible feeling in the gut. I know because I've written several plugins for MQ2 that were stolen by other people and sold as their own, and that just leaves a wrenched feeling in my stomach.
|
We don't make any money off of this project. It isn't like MQ2 where there is money coming in from sales. EQEmu is open source and 100% free. Some of the admins do take money for their server, but most of them only do so to save for part upgrades to make their servers better.
We keep a close eye for any types of wrong doing in these forums. If someone was being wronged, it would be openly discussed (as this is) and whatever it takes to make it right again would be done.
For the record, Kraeger has helped before with his Random Name Generator fix. The entire community is very appreciative of any fixes that come in. I know one of my favorite things about coming here is when I see new server code submissions and get to see what has been fixed!
I think this situation is border-line. No harm or offense was meant in what was done. And, I see nothing blatantly wrong with what KLS did. I do think Kraeger over-reacted a little. And I also think that KLS probably could have added his name in there somehow to avoid this, but I don't blame her for anything. She is a coder after-all, not a customer service representative! I am sure that she wasn't intentionally trying to short-change Kraeger even if he saw it that way. I wouldn't be surprised if she has already changed the note right after this issue was first brought up. It takes a couple of days sometimes for Sourceforge to update that information.
For someone new to this project, I would suggest to please have some patience and keep following the project. This obviously isn't going to give the best impression to someone who just started recently. But I promise that if you keep following these forums you will learn to respect and trust the team. Given that we all have busy lives and things of our own to deal with, I think the team and community here is impeccable. You would have to dig seriously deep in these forums to find issues with the team or the project. And even then, I have never found one that looked anything like there was corruption or greed of any sort. I have probably read more of these forums than 99% of the people here (including very old posts and archives), and I still say that it is a very honest and mature community, team and project minus a very few exceptions here and there.