As Cavedude already said, the option to be able to order the merchant list does have possible uses. Perhaps you want to have a vendor that sells free starter items and a bunch of other items as well. It would be best to have the starter items sort to the top to make starting out just 1 step easier. I can see definite use for this and now that I know that, I might just adjust my starter merchant's table lol.
But, I also agree that it is bad coding not to have it check the merchantlist again before adding more to the merchantlist_temp. It is probably a fairly simple change. Yeah, having the Database accurate is the right way to do it and I think it is important for a database like PEQ which shoots for accuracy and is used by a large number of people. But, for custom servers running custom DBs and merchants, I don't see the need to be quite as anal about it. It is a fairly minor issue to not have them in the proper order, but the bug that results is not as minor. So, if the bug can be fixed, I don't see why not.
Really, I could care less about if my merchants are in order or not. I also don't plan to ever completely update my server to PEQ again just because I don't have much need to since my focus is custom content. But that doesn't mean that I want some merchants to be broken if I ever enabled temp merchant lists. This isn't really an issue either way to me, personally. I am just playing devil's advocate about why it might be good to fix the bug :P
|