View Single Post
  #22  
Old 06-22-2009, 03:01 PM
gaeorn
Developer
 
Join Date: Apr 2009
Location: USA
Posts: 478
Default

KLS, try this patch for va_lists under windows. It defines va_copy if it is not already defined.

Code:
Index: common/MiscFunctions.cpp
===================================================================
--- common/MiscFunctions.cpp    (revision 702)
+++ common/MiscFunctions.cpp    (working copy)
@@ -59,6 +59,10 @@
        #include <errno.h>
 #endif
 
+#ifndef va_copy
+       #define va_copy(d,s) ((d) = (s))
+#endif
+
 void CoutTimestamp(bool ms) {
        time_t rawtime;
        struct tm* gmt_t;
@@ -147,7 +151,7 @@
 int MakeAnyLenString(char** ret, const char* format, ...) {
        int buf_len = 128;
     int chars = -1;
-       va_list argptr;
+       va_list argptr, tmpargptr;
        va_start(argptr, format);
        while (chars == -1 || chars >= buf_len) {
                safe_delete_array(*ret);
@@ -156,7 +160,8 @@
                else
                        buf_len = chars + 1;
                *ret = new char[buf_len];
-               chars = vsnprintf(*ret, buf_len, format, argptr);
+               va_copy(tmpargptr, argptr);
+               chars = vsnprintf(*ret, buf_len, format, tmpargptr);
        }
        va_end(argptr);
        return chars;
@@ -169,7 +174,7 @@
                *strlen = 0;
     int chars = -1;
        char* oldret = 0;
-       va_list argptr;
+       va_list argptr, tmpargptr;
        va_start(argptr, format);
        while (chars == -1 || chars >= (sint32)(*bufsize-*strlen)) {
                if (chars == -1)
@@ -183,7 +188,8 @@
                                memcpy(*ret, oldret, *strlen);
                        safe_delete_array(oldret);
                }
-               chars = vsnprintf(&(*ret)[*strlen], (*bufsize-*strlen), format, argptr);
+               va_copy(tmpargptr, argptr);
+               chars = vsnprintf(&(*ret)[*strlen], (*bufsize-*strlen), format, tmpargptr);
        }
        va_end(argptr);
        *strlen += chars;
Index: common/debug.cpp
===================================================================
--- common/debug.cpp    (revision 702)
+++ common/debug.cpp    (working copy)
@@ -20,6 +20,10 @@
 #endif
 #include "../common/MiscFunctions.h"
 
+#ifndef va_copy
+       #define va_copy(d,s) ((d) = (s))
+#endif
+
 static volatile bool logFileValid = false;
 static EQEMuLog realLogFile;
 EQEMuLog *LogFile = &realLogFile;
@@ -144,13 +148,16 @@
                fprintf(fp[id], "%04i [%02d.%02d. - %02d:%02d:%02d] ", getpid(), newtime->tm_mon+1, newtime->tm_mday, newtime->tm_hour, newtime->tm_min, newtime->tm_sec);
 #endif
 
-       va_list argptr;
+       va_list argptr, tmpargptr;
        va_start(argptr, fmt);
-    if (dofile)
-               vfprintf( fp[id], fmt, argptr );
+    if (dofile) {
+               va_copy(tmpargptr, argptr);
+               vfprintf( fp[id], fmt, tmpargptr );
+       }
        if(logCallbackFmt[id]) {
                msgCallbackFmt p = logCallbackFmt[id];
-               p(id, fmt, argptr );
+               va_copy(tmpargptr, argptr);
+               p(id, fmt, tmpargptr );
        }
     if (pLogStatus[id] & 2) {
                if (pLogStatus[id] & 8) {
@@ -204,17 +211,21 @@
     time( &aclock );                 /* Get time in seconds */
     newtime = localtime( &aclock );  /* Convert time to struct */
 
+    va_list tmpargptr;
+
     if (dofile) {
 #ifndef NO_PIDLOG
                fprintf(fp[id], "[%02d.%02d. - %02d:%02d:%02d] %s", newtime->tm_mon+1, newtime->tm_mday, newtime->tm_hour, newtime->tm_min, newtime->tm_sec, prefix);
 #else
                fprintf(fp[id], "%04i [%02d.%02d. - %02d:%02d:%02d] %s", getpid(), newtime->tm_mon+1, newtime->tm_mday, newtime->tm_hour, newtime->tm_min, newtime->tm_sec, prefix);
 #endif
-               vfprintf( fp[id], fmt, argptr );
+               va_copy(tmpargptr, argptr);
+               vfprintf( fp[id], fmt, tmpargptr );
     }
        if(logCallbackPva[id]) {
                msgCallbackPva p = logCallbackPva[id];
-               p(id, prefix, fmt, argptr );
+               va_copy(tmpargptr, argptr);
+               p(id, prefix, fmt, tmpargptr );
        }
     if (pLogStatus[id] & 2) {
                if (pLogStatus[id] & 8) {
@@ -295,10 +306,12 @@
 }
 
 bool EQEMuLog::writeNTS(LogIDs id, bool dofile, const char *fmt, ...) {
-       va_list argptr;
+       va_list argptr, tmpargptr;
        va_start(argptr, fmt);
-       if (dofile)
-               vfprintf( fp[id], fmt, argptr );
+       if (dofile) {
+               va_copy(tmpargptr, argptr);
+               vfprintf( fp[id], fmt, tmpargptr );
+       }
     if (pLogStatus[id] & 2) {
                if (pLogStatus[id] & 8)
                        vfprintf( stderr, fmt, argptr );
Reply With Quote