View Single Post
  #12  
Old 01-03-2011, 06:44 PM
Fasthand
Fire Beetle
 
Join Date: Dec 2010
Location: Montreal
Posts: 29
Default

Well guess i should not be posting anything that look suspicious, i feel i would get the answer that the code is working perfectly.

Im just reading code for like 3 minutes and i see like 3 things that peek out my attention.

Im not here to bitch at coding or point out fingers, i just want to get it fix for the benefits of the community.

is the mana_regen_rate means to be a multiplier on how fast the bot was suppose to regen their mana, cause if it so ... why dividing it... ie: if i set variable to 5.0 i was thinking it should be 5x faster and not 1/5 ... you guys divide at the end instead of multiplying. (i dont have raw data on all the variables so i might be wrong, but that looks wrongs).

Code:
regen = (regen * RuleI(Character, ManaRegenMultiplier)) / 100;
float mana_regen_rate = RuleR(Bots, BotManaRegen);
if(mana_regen_rate < 1.0f)
   mana_regen_rate = 1.0f;
regen = regen / mana_regen_rate; <==== thats look weird 
SetMana(GetMana() + regen);
Yes i know code is working ... and working as intended ... now can we drop out that anemosity i feel ... or i should just fix things on my side and forget to keep your guys up to date?

Fasthand aka
s0rCieR MQ2 plugin grand daddy!
Reply With Quote