I agree that a better fix would be to not allow trading to a bot while engaged, but as a side effect of moving some calculations around in CalcBotStats, it no longer sets the current hp/mana to max within it. As that is called when an item is traded to a bot, it no longer set their current hp/mana to their max at that time. Since I was trying to fix the changes that I had submitted a month and a half ago, I didn't want to have to retest more code (to not allow trading while in combat). I had just seen some comments about it being a problem, and noticed that these changes effectively eliminated that problem. I do plan on making more changes and submitting them, and I can work on a real fix for that issue, but I just wanted to get it submitted now.
As for the GetSkill() and GetItem(), I agree with you. I prefer using the name rather than the number, but I missed changing the getItem() since I just copied that code in from the client code. I think the GetSkill(Dodge) stuff was Caryatis' as well. He made a few changes to my code when he committed it, and I made sure to keep his changes in there.
Thanks for the feedback.
|