Thread: Bot Beg Buff
View Single Post
  #8  
Old 01-03-2014, 02:48 PM
demonstar55
Demi-God
 
Join Date: Apr 2008
Location: MA
Posts: 1,164
Default

Just a couple things to note:

Having comments like your name/date are rather pointless (we use version control software to keep track of that)

We use strcasecmp to compare strings case insensitively. On Windows this is just defined to stricmp, on UNIX it just uses the libc extension strcasecmp. (so you can replace strupr and strcmp)

And I believe (from quickly looking through the other bot code) that the bots Say function works like printf family does. So Say("Butts %s", spell_name); kind of thing should work (so you can remove the char buffer and call to sprintf, it internally does use a buffer and printf stuff, but it's nicer :P)

I would highly recommend looking into making a pull request on GitHub if you would like to see this included, if setting up GitHub is too much, you can always make a post with a unified diff in the code submissions forum.

This post http://eqemulator.org/forums/showthread.php?t=36515 might help with some git stuff.

Personally, I probably wouldn't pull this since I've never touched the bots stuff so I would leave it up to someone else :P
Reply With Quote