Nice find!
http://stackoverflow.com/questions/3...ng-constructor
Not sure who wrote that originally..but, yes, the stream is initialized with the provided string without setting the stream's write position - it is still set to '0'
Personally, I don't use the string constructor of a stringstream, so I definitely missed that one.
I'll push a fix for that today.
EDIT:
Quote:
EDIT: Fixed by changing both entries to this (2nd Edit: Also I had to remove your brackets for the order of precedence around the disabletask conditional as it caused issues);
|
Can you elaborate on the issue caused by this?
There is a scope declaration around the enabletask query builder that does the exact same thing.
EDIT2: I pushed with the inner scope declaration. If you can explain why this is an issue, I'll look at it and either fix or address the issue.