Throwing is Broken in SVN

[trevius]

I am not sure if maybe something I have custom on my server is breaking this or not, but I am pretty sure it isn't just my server. I am running one of the latest SVN revisions and currently, Throwing is broken on it. I don't know exactly when it broke, but I did notice it wasn't working a couple of weeks ago. I had forgotten about it until a player actually mentioned it to me yesterday.

I looked through the code and couldn't find anything that stood out as wrong, but I probably either just missed it, or I was looking in the wrong place.

The current problem is that it actually seems to work in every way accept that the NPC won't be hit by the actual damage from the thrown item. You hit ranged attack, and it removes 1 ammo as it should, it also does the animation of throwing for the client and even the animation of being hit for the NPC lol. But, the NPC will not aggro and they won't take damage or show any hit/miss messages in the combat log.

I actually first noticed the problem when testing out Berserker Disciplines. I didn't think much of it because I figured it was just an issue with the disciplines themselves. The odd thing is that some of the Bers discs have a chance to do special things like stun, or mez, etc. Those special effects from the discs were actually working. If the npc got hit by a throw with one of those disciplines, they would get stunned or whatever just like they should and then they would also aggro like normal. So, it is almost like everything is working accept for the actual weapon damage from throwing items.

I don't know if this has anything to do with there being 2 different types of throwing in the source (Throwing and Throwingv2), but it might. I am not sure why there would be 2 types offhand.

I will try to look into this more when I get time, but I figured I would mention it here in case someone may have been doing something related to throwing that might have caused it. Then they could figure out the cause much quicker to resolve it than I could. I guess maybe doing some diffs wouldn't hurt, but I don't know exactly when the problem started, which makes using diffs tough lol.