Mmf_eqmax_items=100,000?

[John Adams]

FYI to devs;

In Item.h, there is this define:

#define MMF_EQMAX_ITEMS		100000

And in wandering through some of the latest `items` table data, the max ID is currently 99211 (Shiliskin Dagger). I might misunderstand the meaning of this #define, but if our items break the 100k mark, will we have troubles?

I once manually created an item > 100,000 and it did not work. I cannot remember if I crashed, or if I just couldn't find it (was ID 150,000 for custom items).

Just thought I'd bring it up in case it becomes an issue on the next Items import.

-J

[image]

The way memshare works is it allocates memory space for a given amount of items, npcs, doors, etc (Everything that is handled in memshare has a #), if you exceed the ID number of the maximum, you have to increase it and re-compile.

[GeorgeS]

I'm slowly rewriting the item editor code to use a smarter way of finding the next available item_id, instead of using SELECT MAX(id) FROM ITEMS...
In this way it will not go over 100K limit.


GeorgeS

[image]

When you insert into a table using MySQL you are able to pass in a integer to retrieve the unique insert id, this would probably be the best way by just letting mysql decide the newest ID.

[John Adams]

Right, Image. So long as someone knows that time is coming. I think that item ID was the latest from 13th Floor, as of May.

Will the shared memory just not load those 100k+ items? Or will it crap something out? I think the former is true. I can't remember. i guess I could just go create item id's 100,000 through 100,100 and see if they show up.

[image]

Well you are confusing me, you are talking about an item editor and then you are bringing up code for the emulator. If you have item ID's that exceed that define, the items simply will not load into EQEMu's memshare because it needs more memory space. There is no other way around it other than increasing the define to exceed the highest item id number.

[John Adams]

No, I was talking about Emu only... not the item editor. Sorry for not being clear. I actually created my item by inserting a new SQL row manually. I'm a barbarian at heart.

But thanks for clearing it up.

[gernblan]

100k should be enough for anybody.

Or was that 640k?

[gernblan]

Originally Posted by GeorgeS

I'm slowly rewriting the item editor code to use a smarter way of finding the next available item_id, instead of using SELECT MAX(id) FROM ITEMS...
In this way it will not go over 100K limit.


GeorgeS

Thank you, GeorgeS. That is badly needed for sure. It will be helpful also to fill in gaps in the items table this way.