Spell Casting Mastery

[provocating]

Anyone know why SCM is checking against a random? I was under the understanding that it was a passive always on ability and should not be random.

https://github.com/EQEmu/Server/blob...ne/effects.cpp

I put some extra logging in the code so I can get a feel for what is going on and it is rather rare there are any spell savings at all.

	if(SuccessChance <= (SpecializeSkill * 0.3 * bonus))
	{
		PercentManaReduction = 1 + 0.05f * SpecializeSkill;
		switch(GetAA(aaSpellCastingMastery))
		{
		case 1:
			PercentManaReduction += 2.5;
			break;
		case 2:
			PercentManaReduction += 5.0;
			break;
		case 3:
			PercentManaReduction += 10.0;
			break;
		}

		switch(GetAA(aaAdvancedSpellCastingMastery))
		{
		case 1:
			PercentManaReduction += 2.5;
			break;
		case 2:
			PercentManaReduction += 5.0;
			break;
		case 3:
			PercentManaReduction += 10.0;
			break;
		}
	}