Secrets of Faydwer - Bug Tracking

[trevius]

This post is created to allow us to track bug reports with Secrets of Faydwer. A current list of the known issues for development tracking can be seen here:

http://www.eqemulator.net/forums/showthread.php?t=27429

If you find a bug that is not already on that list, please post it in this thread (not the development thread linked above) and I will get it added to that list. The list is updated regularly, so check back for current status and updates on bug reports and resolutions.

Here is a list of some of the known issues/bugs with SoF and what is known about them:
1. /who - /who actually works almost perfectly now. But, if you search for /who <name> or use /whotarget, it returns all players in the current zone.
2. Item Trading - Appears trading items may not always work perfectly. This is almost certainly a slot issue with the trade window and can probably be corrected with an adjustment to the encode/decode of it.

Unverified Bug Reports:
1. Disciplines Failing - Reports of some disciplines failing to execute. I think this happens on all clients.

SoF Bugs with the client iself:
1. Highhold Keep - From the brief testing I did on this, it appears that trying to enter the old HHK zone causes the client to crash and it needs to be moved out of the zone for them to be able to log in again. The old HHK zone was removed from the newer clients, and so they cannot access that zone.


Fixed Bugs from this post:
1. Fast Food/Drink Consumption - Food and Drink now get consumed at the proper rate.
2. Throwing/Ranged Animation - The throwing animation is now working (thanks Derision!)
3. Animation - All Animation issues are now resolved (thanks Derision!)
4. Drakkin Corpses - Drakkin corpses (as well as Froglok corpses) now show properly even after a zone dump occurs (thanks Derision!)
5. Spell Fizzles - After fizzling a spell, there is an especially long delay before the spell can be recast. It appears that there may be different ways of handling spell fizzles in SoF. In Titanium, I believe it was treated like a normal spell interrupt.
6. Disconnect on Death - You are no longer disconnected on Death in SoF.
7. Potion Belt - Potion belt appears to function correctly now.
8. Total Spent AAs - This is now reported correctly for all clients including SoF and SoD.

I will add more to this list later.

[ChaosSlayerZ]

this not gonna screw up the actual tribute in anyway? Not that I care much for tribute, but I am just curious.
Also - since this is a fix for SoF - will people running T be adversely affected?
Since post 75 T client shows hp correctly already.

[Davood]

Originally Posted by ChaosSlayerZ

this not gonna screw up the actual tribute in anyway? Not that I care much for tribute, but I am just curious.
Also - since this is a fix for SoF - will people running T be adversely affected?
Since post 75 T client shows hp correctly already.

Well in the sever handshake; the server knows if the client is running titanium or SoF; therefore you can run the extra code just for the SoF clients.

[KLS]

That or you can not be lazy and I don't know account for the tribute in there too. That's what I meant by somewhat complicated.

[Secrets]

I hacked up the tribute code and came up with this.

tribute.cpp, replaced the entire function

void Client::DoTributeUpdate() {
	
	const Item_Struct* myitem = database.GetItem(1001);
	Item_Struct* item = (Item_Struct*) malloc(sizeof(Item_Struct));
	memcpy(item, myitem, sizeof(Item_Struct));

	if(GetLevel() >= 76 && this->GetClientVersion() == EQClientSoF)
	{
		item->HP += (CalcBaseHP() - 5);
		item->Mana += (CalcMaxMana() - 5);
		item->Endur += (this->max_end - 5);
	}


	const Item_Struct* item2 = item;
	ItemInst* myinst = database.CreateBaseItem(item2);
	SendFakeItem(400, myinst, ItemPacketTributeItem);
			return;
			
}

inventory.cpp, new function

void Client::SendFakeItem(sint16 slot_id, ItemInst* inst, ItemPacketType packet_type)
{

	if (!inst) 
		return;
	
	// Serialize item into |-delimited string
	string packet = inst->Serialize(slot_id);
	
	EmuOpcode opcode = OP_Unknown;
	EQApplicationPacket* outapp = NULL;
	ItemPacket_Struct* itempacket = NULL;
	
	// Construct packet
	opcode = (packet_type==ItemPacketViewLink) ? OP_ItemLinkResponse : OP_ItemPacket;
	outapp = new EQApplicationPacket(opcode, packet.length()+sizeof(ItemPacket_Struct));
	itempacket = (ItemPacket_Struct*)outapp->pBuffer;
	memcpy(itempacket->SerializedItem, packet.c_str(), packet.length());
	itempacket->PacketType = packet_type;
	
#if EQDEBUG >= 9
		DumpPacket(outapp);
#endif
	//DumpPacket(outapp);
	FastQueuePacket(&outapp);

}

and the corresponding header function in Client.h

void	SendFakeItem(sint16 slot_id, ItemInst* inst, ItemPacketType packet_type);

and lastly, make it so every time a player gains a level that it recalculates tributes & sends a new item, effectively granting the player a new stat, exp.cpp:

		DoTributeUpdate();

near

 CalcBonuses();
        if(!RuleB(Character, HealOnLevel))
        {
                int mhp = CalcMaxHP();
                if(GetHP() > mhp)
                        SetHP(mhp);
        }
        else
        {
                SetHP(CalcMaxHP());             // Why not, lets give them a free heal
        }
		DoTributeUpdate();
        SendHPUpdate();
        SetMana(CalcMaxMana());
        UpdateWho();
        Save();

that should do it. most of the hard work is done.

Also, I would change 1001 to a blank item, or use a non-used ID like 10 for the item. That will resolve adding AC to the client.

Other than that, it works.

[Secrets]

Originally Posted by Secrets

and lastly, make it so every time a player gains a level that it recalculates tributes & sends a new item, effectively granting the player a new stat, exp.cpp:

I would actually add it into CalcBonuses(); near the end, since that's the most logical place for it, seeing as it needs to be updated every time your hp/mana/end is changed, now that I think about it :p

[Secrets]

As per KLS' suggestion, I should use new instead of malloc(), so I am going to. I should also free memory :P

void Client::DoTributeUpdate() {
	
	const Item_Struct* myitem = database.GetItem(1001);
	Item_Struct* item = new Item_Struct;
	memcpy(item, myitem, sizeof(Item_Struct));

	if(GetLevel() >= 76 && this->GetClientVersion() == EQClientSoF)
	{
		item->HP += (CalcBaseHP() - 5);
		item->Mana += (CalcMaxMana() - 5);
		item->Endur += (this->max_end - 5);
	}


	const Item_Struct* item2 = item;
	ItemInst* myinst = database.CreateBaseItem(item2);
	SendFakeItem(400, myinst, ItemPacketTributeItem);
	delete item;
        delete myinst;
	return;
			
}

[joligario]

Not new on Titanium as far as I can remember. Do you have any spell time reduction items or AAs? I think that's when I started noticing the short casting time.

[Midgett]

Not new on Titanium as far as I can remember. Do you have any spell time reduction items or AAs? I think that's when I started noticing the short casting time.

I started a new druid and #level him to 70. I then scribed beneficial spells to test. With no AAs and no gear, the casting bar empties before the spell lands. So I went through and only equiped one item at a time to see if I could track it down. With no AAs still, I tracked it down to 'Elegant Defiant Leather Boots'. It does have an effect that reduces casting time.

Usually when an AA or piece of gear reduces casting time, that usually means the casting bar starts at the new reduced time and empties out before the spell lands (ex. Egress and evac spells with AAs). That doesn't seem to be the case here. It's not finishing before the spell lands.

As for the appearance bug, no AA or piece of gear seems to have an effect.

I haven't played EQ since PoR expansion so things might have changed since the day. I am going by past memories; but then again, I didn't have gear that nice when I quit. :-P

Hope this helps!