Wrong Section? Merchant's Items Mislabeled?

[Fatboy5706]

Well, I play on PEQ, and I went to buy Crushed Black Marble from a merchant and it gave me a steel collar instead, 70pp waste, and then I tried to buy a Flawless Diamond and it gave me a cog... not much pp wasted on the cog. The CBM was only 31pp and it charged me 178pp for the steel collar. I do not care about the pp, but something needs to be fixed. Move this to appropriate section if need be wasn't sure where to make this. Thanks in advance.

[Fatboy5706]

Might need to be moved to bug section, sorry for the inconvenience.

[trevius]

NP, I moved it to bugs. Sounds like a possible issue with the Temp merchant code. I know it was changed considerably lately. Sounds like it is worth investigating.

[Fatboy5706]

You could keep me updated on the situation Trevius (am I allowed to capitalize that?), I know fixing things like this take time I am not rushing the resolution. Just a tidbit here and there would be helpful. Thanks in advance.

[So_1337]

Cavedude responded over on PEQ if you'd like to follow up there. He's looking for the merchant's name that you were using.

http://www.projecteq.net/phpBB2/viewtopic.php?t=5918

[cavedude]

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

[ChaosSlayer]

Originally Posted by cavedude

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

cavedude - could you be a little bit more specific how to "reorder" them?
or even better how to prevent this from happening?

thanks =)

[cavedude]

The slot column in merchantlist on a given merchant has to be in order, with no gaps. If you have a have items in slots 1, 2, 3, and 5 let's say what happens is if a player sells an item to that merchant it uses the first available slot. In this case 4. The problem arises when the next player sells an item to the merchant. It'll go in slot 5, even though an item already exists there because the server knows 4 is home to a player sold item, via merchantlist_temp.

The code should probe merchantlist before assigning a slot to merchantlist_temp to make sure it isn't already in use. That will correct the issue. However, since the slots should be in order anyway that's a moot point.