Class Specific quest

[paaco]

I am attempting to make a quest in my noobie zone that gives class specific rewards. However when you hail him, he gives you the text, but then when you hand him a mold for your wep he does nothing :( Can anyone tell me what is wrong in the format for this? Thank you any that can reply and help me get this working.

sub EVENT_SAY {
    if ($text=~/hail/i) {
      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");}
    }
    
sub EVENT_ITEM {
  if ($class == Warrior)
    (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Paladin)
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Shadow Knight) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Berserker) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Monk) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Beastlord) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Druid) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Necromancer) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }    
    elsif ($class == Wizard) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Magician) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Enchanter) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Shaman) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    elsif ($class == Cleric) {
      (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29442);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    else {
      plugin::return_items(\%itemcount); 
      quest::say("These are not the pieces I need.");
  }
}

Also note that I have tried this with the class name typed out like in my posted code. and with the class ID#. Same result both ways.
elsif ($class == Paladin)

[fathernitwit]

if($class == "Warrior")

missing quotes

[Muuss]

sub EVENT_ITEM {
  if ($class == Warrior)
    (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }

missing && between $class=="Warrior" and the check_handin
or miswritten tests.

I would write it that way :

sub EVENT_ITEM {
  if (($class == "Warrior") && (plugin::check_handin(\%itemcount, 6164 => 1))) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }

  if (($class == "Paladin") && (plugin::check_handin(\%itemcount, 6164 => 1))) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }

   ...
   ...
  plugin::return_items(\%itemcount);
}

[Muuss]

Forgot to write this, after you wrote a quest, you can test its syntax with perl :

perl -cw 'questfile.pl'

This will help you to fix some of the errors you made.

[Muuss]

What i wrote previously has a correct syntax but won't work due to recent changes in the plugin::check_handin method.

You MUST write your quest like that :

sub EVENT_ITEM {
  if ($class =="Warrior") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
       ... do stuff here
    }
  }

  if ($class == "Paladin") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
       ... do stuff here
    }
  }

  ...
  ...

  plugin::return_items(\%itemcount);
}

In my previous code, the test for the paladin would never be valid because the item will disappear of the list during the warrior's test. I m still not used to that new check_handin, sorry for the error

[paaco]

Thanks a lot guys, With the info you gave I'm sure I can get it working.