Hate modifiers patch

[blmille2]

Hello, all--it's been a while since my last code submission, so I'm sorry about that.

Someone asked me to fix the hate modifiers so that they work--for worn effects, spells (i.e. Enchanter Horrifying Visage, etc.), and AAs (if there be any hate modifiers currently implemented).

Here's a really simple patch that I think fixes the issue:

Index: zone/attack.cpp
===================================================================
--- zone/attack.cpp	(revision 1603)
+++ zone/attack.cpp	(working copy)
@@ -1253,6 +1253,7 @@
 			other->MeleeMitigation(this, damage, min_hit);
 			ApplyMeleeDamageBonus(skillinuse, damage);
 			TryCriticalHit(other, skillinuse, damage);
+			hate += damage * 100 *(this->spellbonuses.hatemod + this->itembonuses.hatemod + this->aabonuses.hatemod)/100;
 			mlog(COMBAT__DAMAGE, "Final damage after all reductions: %d", damage);
 		}

[blmille2]

Wow, sorry about that -- that'd would produce an insane amount of hate.

Here's the update:

Index: zone/attack.cpp
===================================================================
--- zone/attack.cpp	(revision 1603)
+++ zone/attack.cpp	(working copy)
@@ -1253,6 +1253,7 @@
 			other->MeleeMitigation(this, damage, min_hit);
 			ApplyMeleeDamageBonus(skillinuse, damage);
 			TryCriticalHit(other, skillinuse, damage);
+			hate += damage * (this->spellbonuses.hatemod + this->itembonuses.hatemod + this->aabonuses.hatemod)/100;
 			mlog(COMBAT__DAMAGE, "Final damage after all reductions: %d", damage);
 		}

[trevius]

Are hate modifiers not working without this patch? I thought they were already functional.

[blmille2]

I think they are getting calculated, but I followed the hit code and found no reference to it. This should allow warrior epic 2.0 and enchanter hate buffs to add hate.
Greenmachine noticed that the warrior epic 2.0 wasn't working, which prompted investigation. Note this is for effects and not procs.

Thanks!

[ghostriderdoom]

Originally Posted by blmille2

I think they are getting calculated, but I followed the hit code and found no reference to it. This should allow warrior epic 2.0 and enchanter hate buffs to add hate.
Greenmachine noticed that the warrior epic 2.0 wasn't working, which prompted investigation. Note this is for effects and not procs.

Thanks!

Epic 1.5 to be clear actually. And the focus effect it has just never felt like it did anything. I have had the warrior epic 1.5 for a year now. I didn't notice any change in aggro from getting the item.

[Caryatis]

Seems like this wouldn't accurately reflect agro from live as there is no additional agro for crits, however with the code structured like that, on crits your hate would be doubled. Also Im pretty sure that agro on live is based on weapon dmg, not actual dmg, which is why war weapons from recent expansions have less dmg/dly with relatively high elemental dmg tacked on(The Keen Edge of Discord vs Skulltutor). This keeps the war agro high but their dps in check, however that is not entirely relevant to your change and seems to be in the code already.

That said, it should be a relatively easy effect to test(feel doesnt really cut it, especially with 15%), use an item like Raex's Chestplate of Destruction and check the hatelist entries with and without it.