Client Crash - adding to stacks in inventory

[AdrianD]

The client crashes and eventuallly boots to character selection after, what seems to be, a loss of communication when purchasing items which add to an existing stack in inventory. This does not kick other clients from what I can tell as I had two separate accounts logged on separate machines.

When entering the game after this occurs, the items are a part of the stack and no cash was subtracted from the character's holdings.

Another stack-transfer related quirk occurs when one character trades with another with the recipient having a partial stack of what is being traded, for example, food. The item does not add to the existing stack. It simply becomes a part of the character's inventory in it's own private slot.

While the latter issue isn't a big deal, I believe the two are related.

* I changed the database value of many of the stack sizes in `items.stacksize`.

Any ideas?

[Uleat]

A zone crash would kick all clients.

Smart Trades: www.eqemulator.org/forums/showthread.php?t=38675


I'll take a look through the code to see what conditions might cause this..but, I haven't heard of any issues since the last post
in that thread.

Post some examples of your stacksize changes (before -> after)

Did you re-run shared_memory.exe after making these changes?

[AdrianD]

This does not kick other clients from what I can tell as I had two separate accounts logged on separate machines.

It does, in fact, crash the zone if the clients are sharing it. Therefore, the statement I made above is incorrect if within the same zone. The above should read, for clarification "This kicks other clients when in the same zone but does not kick them when outside the zone where the transfer takes place."

I used the queries below to alter many/most of the items which had large stacksizes. After, I used the searches to alter individual items by changing items.stackable = 0 for items which were not stackable at an earlier time.

# stacksize item search
select distinct items.id,items.name,items.stacksize,items.slots,it ems.stackable from items
where stacksize > 20;

select distinct items.id,items.name,items.stacksize,items.slots,it ems.stackable from items
where stacksize > 19 and stacksize < 21 order by id;

select distinct items.id,items.name,items.stacksize,items.slots,it ems.stackable from items
where stacksize > 1 and stacksize < 21 and (name like '%block%' or name like '%brick%') order by id;

select distinct items.id,items.name,items.stacksize,items.slots,it ems.stackable from items
where stacksize > 1 and stacksize < 21 and (name like '%skin%' or name like '%pelt%') order by id;

# stacksize update
update items set stacksize = 20 where stacksize < 401 and stacksize > 19;
update itemstemp set stacksize = 20 where slots < 2099201 and slots > 2097151;

Disclaimer:
These were some of the first queries I wrote for changes made to the main DB I use to create my `expansions`. Forgive me if they are not the most efficient.

I don't keep the server up very often. It's up when I play/test or if I forget to turn it off. Shared_memory.exe is restarted often because of this.

I restart the server using this batch for EQEmu login:

@echo off
shared_memory.exe
start world.exe
echo This should be played at high volume, preferably in a residential area...
ping -n 10 127.0.0.1 > nul
start queryserv.exe
start ucs.exe
start eqlaunch.exe zone
exit

Thanks for the link and your help.

[AdrianD]

Rather than add to an already longish post, I'll start a new.

I tested some specifics and had these results:

Scenario 1 -

Merchant transfer to PC, non-stackable

Shows up in DB tables inventory, merchantlist_temp, qs_merchant tables

Works as it should

Scenario 2 -

Merchant transfer stackable

Crashes zone immediately

Client UI gives appearance of successful barter

Shows up in DB table inventory and merchantlist_temp but not qs_merchant tables

Upon logging back the item stack is what was intended but no cash was removed

This result is the same regardless of using merchantlist_temp or merchantlist although I noticed some strange things with what the temp table shows vs what the NPC in game shows. For example: this merchant has two separate entries in his temp table for item 13073, bone chips.

I purchased the stack which appears not to change and, not only did the character not receive the items, cash was removed and the merchantlist_temp table showed item as still being there. The client showed no instance of the item in the merchant UI and the other stack disappeared, as well. Upon logging back both stacks of the same item were present when checking the merchant.

I will clear the temp table and try it again.

* Same happened with an empty merchantlist_temp table.

[AdrianD]

Here's a long one:

---------------------------------------------
[07.26. - 23:05:35] Starting Log: logs/crash_zone_5036.log
[07.26. - 23:05:35] EXCEPTION_ACCESS_VIOLATION
[07.26. - 23:05:35] SymInit: Symbol-SearchPath: '.;C:\EQ\EQEmuServer;C:\EQ\EQEmuServer;C:\Windows; C:\Windows\system32;SRV*C:\websymbols*http://msdl.microsoft.com/download/symbols;', symOptions: 530, UserName: 'Dude'
[07.26. - 23:05:35] OS-Version: 6.1.7601 (Service Pack 1) 0x100-0x1
[07.26. - 23:05:35] C:\EQ\EQEmuServer\zone.exe:zone.exe (01100000), size: 23429120 (result: 0), SymType: 'PDB', PDB: 'C:\EQ\EQEmuServer\zone.exe'
[07.26. - 23:05:35] C:\Windows\SysWOW64\ntdll.dll:ntdll.dll (772C0000), size: 1572864 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SysWOW64\ntdll.dll', fileVersion: 6.1.7601.18247
[07.26. - 23:05:35] C:\Windows\syswow64\kernel32.dll:kernel32.dll (74D70000), size: 1114112 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\kernel32.dll', fileVersion: 6.1.7601.18409
[07.26. - 23:05:35] C:\Windows\syswow64\KERNELBASE.dll:KERNELBASE.dll (76060000), size: 290816 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\KERNELBASE.dll', fileVersion: 6.1.7601.18409
[07.26. - 23:05:36] C:\Windows\syswow64\SHELL32.dll:SHELL32.dll (75140000), size: 12886016 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SHELL32.dll', fileVersion: 6.1.7601.18429
[07.26. - 23:05:36] C:\Windows\syswow64\msvcrt.dll:msvcrt.dll (75FB0000), size: 704512 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\msvcrt.dll', fileVersion: 7.0.7601.17744
[07.26. - 23:05:36] C:\Windows\syswow64\SHLWAPI.dll:SHLWAPI.dll (76780000), size: 356352 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SHLWAPI.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\syswow64\GDI32.dll:GDI32.dll (76140000), size: 589824 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\GDI32.dll', fileVersion: 6.1.7601.18275
[07.26. - 23:05:36] C:\Windows\syswow64\USER32.dll:USER32.dll (76DC0000), size: 1048576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\USER32.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\syswow64\ADVAPI32.dll:ADVAPI32.dll (765A0000), size: 655360 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\ADVAPI32.dll', fileVersion: 6.1.7601.18247
[07.26. - 23:05:36] C:\Windows\SysWOW64\sechost.dll:sechost.dll (74F20000), size: 102400 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SysWOW64\sechost.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\syswow64\RPCRT4.dll:RPCRT4.dll (76310000), size: 983040 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\RPCRT4.dll', fileVersion: 6.1.7601.18205
[07.26. - 23:05:36] C:\Windows\syswow64\SspiCli.dll:SspiCli.dll (74CE0000), size: 393216 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SspiCli.dll', fileVersion: 6.1.7601.18443
[07.26. - 23:05:36] C:\Windows\syswow64\CRYPTBASE.dll:CRYPTBASE.dll (74CD0000), size: 49152 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\CRYPTBASE.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\syswow64\LPK.dll:LPK.dll (76300000), size: 40960 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\LPK.dll', fileVersion: 6.1.7601.18177
[07.26. - 23:05:36] C:\Windows\syswow64\USP10.dll:USP10.dll (766E0000), size: 643072 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\USP10.dll', fileVersion: 1.626.7601.18009
[07.26. - 23:05:36] C:\Perl\bin\perl512.dll:perl512.dll (28000000), size: 1273856 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\bin\perl512.dll', fileVersion: 5.12.3.1204
[07.26. - 23:05:36] C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18201_none_ec8 0f00e8593ece5\COMCTL32.dll:COMCTL32.dll (74960000), size: 540672 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18201_none_ec8 0f00e8593ece5\COMCTL32.dll', fileVersion: 5.82.7601.18201
[07.26. - 23:05:36] C:\EQ\EQEmuServer\lua51.dll:lua51.dll (10000000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\EQ\EQEmuServer\lua51.dll', fileVersion: 5.1.4.0
[07.26. - 23:05:36] C:\Program Files (x86)\Lua\5.1\lua5.1.dll:lua5.1.dll (00240000), size: 167936 (result: 0), SymType: '-exported-', PDB: 'C:\Program Files (x86)\Lua\5.1\lua5.1.dll', fileVersion: 5.1.4.0
[07.26. - 23:05:36] C:\Windows\WinSxS\x86_microsoft.vc80.crt_1fc8b3b9a 1e18e3b_8.0.50727.6229_none_d089f796442de10e\MSVCR 80.dll:MSVCR80.dll (74640000), size: 634880 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\WinSxS\x86_microsoft.vc80.crt_1fc8b3b9 a1e18e3b_8.0.50727.6229_none_d089f796442de10e\MSVC R80.dll', fileVersion: 8.0.50727.6229
[07.26. - 23:05:36] C:\Windows\syswow64\WS2_32.dll:WS2_32.dll (760F0000), size: 217088 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\WS2_32.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\syswow64\NSI.dll:NSI.dll (77290000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\NSI.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\VERSION.dll:VERSION.dll (736B0000), size: 36864 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\VERSION.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\apphelp.dll:apphelp.dll (71540000), size: 311296 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\apphelp.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\AppPatch\AcLayers.DLL:AcLayers.DLL (74780000), size: 577536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\AppPatch\AcLayers.DLL', fileVersion: 6.1.7601.17974
[07.26. - 23:05:36] C:\Windows\syswow64\ole32.dll:ole32.dll (76400000), size: 1425408 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\ole32.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\syswow64\OLEAUT32.dll:OLEAUT32.dll (76640000), size: 585728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\OLEAUT32.dll', fileVersion: 6.1.7601.17676
[07.26. - 23:05:36] C:\Windows\system32\USERENV.dll:USERENV.dll (71F10000), size: 94208 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\USERENV.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\system32\profapi.dll:profapi.dll (71F80000), size: 45056 (result: 0), SymType: '-nosymbols-', PDB: 'C:\Windows\system32\profapi.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\WINSPOOL.DRV:WINSPOOL.DRV (74840000), size: 331776 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\WINSPOOL.DRV', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\system32\MPR.dll:MPR.dll (74820000), size: 73728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\MPR.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\IMM32.DLL:IMM32.DLL (74F40000), size: 393216 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\IMM32.DLL', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\syswow64\MSCTF.dll:MSCTF.dll (76910000), size: 835584 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\MSCTF.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\NLAapi.dll:NLAapi.dll (719C0000), size: 65536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\NLAapi.dll', fileVersion: 6.1.7601.17761
[07.26. - 23:05:36] C:\Windows\system32\napinsp.dll:napinsp.dll (719B0000), size: 65536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\napinsp.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\pnrpnsp.dll:pnrpnsp.dll (71990000), size: 73728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\pnrpnsp.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\System32\mswsock.dll:mswsock.dll (71E90000), size: 245760 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\mswsock.dll', fileVersion: 6.1.7601.18254
[07.26. - 23:05:36] C:\Windows\system32\DNSAPI.dllNSAPI.dll (71940000), size: 278528 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\DNSAPI.dll', fileVersion: 6.1.7601.17570
[07.26. - 23:05:36] C:\Windows\System32\winrnr.dll:winrnr.dll (71930000), size: 32768 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\winrnr.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Program Files (x86)\Bonjour\mdnsNSP.dll:mdnsNSP.dll (71900000), size: 135168 (result: 0), SymType: '-exported-', PDB: 'C:\Program Files (x86)\Bonjour\mdnsNSP.dll', fileVersion: 3.0.0.10
[07.26. - 23:05:36] C:\Windows\system32\Iphlpapi.DLL:Iphlpapi.DLL (71B70000), size: 114688 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\Iphlpapi.DLL', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] C:\Windows\system32\WINNSI.DLL:WINNSI.DLL (71B60000), size: 28672 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\WINNSI.DLL', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\system32\rasadhlp.dll:rasadhlp.dll (748E0000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\rasadhlp.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\System32\wshtcpip.dll:wshtcpip.dll (71E80000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\wshtcpip.dll', fileVersion: 6.1.7600.16385
[07.26. - 23:05:36] C:\Windows\System32\fwpuclnt.dll:fwpuclnt.dll (748A0000), size: 229376 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\fwpuclnt.dll', fileVersion: 6.1.7601.18283
[07.26. - 23:05:36] C:\Windows\system32\dbghelp.dll:dbghelp.dll (69F00000), size: 962560 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\dbghelp.dll', fileVersion: 6.1.7601.17514
[07.26. - 23:05:36] c:\eq\source\zone\client_packet.cpp (5699): Client::Handle_OP_ShopPlayerBuy
[07.26. - 23:05:36] c:\eq\source\zone\client_packet.cpp (483): Client::HandlePacket
[07.26. - 23:05:36] c:\eq\source\zone\client_process.cpp (699): Client::Process
[07.26. - 23:05:36] c:\eq\source\zone\entity.cpp (500): EntityList::MobProcess
[07.26. - 23:05:36] c:\eq\source\zone\net.cpp (430): main
[07.26. - 23:05:36] f:\dd\vctools\crt\crtw32\startup\crt0.c (255): __tmainCRTStartup
[07.26. - 23:05:36] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 74D8338A)
[07.26. - 23:05:36] 74D8338A (kernel32): (filename not available): BaseThreadInitThunk
[07.26. - 23:05:36] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 772F9F72)
[07.26. - 23:05:36] 772F9F72 (ntdll): (filename not available): RtlInitializeExceptionChain
[07.26. - 23:05:36] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 772F9F45)
[07.26. - 23:05:36] 772F9F45 (ntdll): (filename not available): RtlInitializeExceptionChain

Thanks Uleat.

[AdrianD]

If you have any of the logging systems enabled, try locating an entry for the transaction that caused the crash.

Since you're dealing with currency, you might look for a division-by-zero error.

Can I be pointed in the direction of where to find these or where to enable them?

I apologize for not knowing. You could say I jumped into a pool of sharks before knowing there were sharks.

[Uleat]

Posting the crash dump of the zone server that crashed would be immensely helpful. It should be in the '\logs\crash' folder.

This is a good place to look for issues: https://github.com/EQEmu/Server/blob...ket.cpp#L12006

If you have any of the logging systems enabled, try locating an entry for the transaction that caused the crash.

Since you're dealing with currency, you might look for a division-by-zero error.


Post your log and go over what you can find and we'll see where that takes us.

[Uleat]

I 'think' a division by zero error would be declared at the top of the crash log..never seen one in a log myself.

You're showing an "EXCEPTION_ACCESS_VIOLATION," which should be traceable.


[deleted - not even close...]

(How old is your code? Handle_OP_ShopPlayerBuy is nowhere close to line 5699)

Give me a few minutes and I'll look over that part of the code and try to get some pointers back to you.


EDIT: For the client to be updated, you would need to at least reach this far: https://github.com/EQEmu/Server/blob...ket.cpp#L12184

Do you have 'RuleB(QueryServ, PlayerLogMerchantTransactions)' enabled?

Shows up in DB table inventory and merchantlist_temp but not qs_merchant tables

Ok, from what I can remember, QS is not supposed to log stackable items due to problems with item tracking across multiple stacks.

Did you enable it by chance?

I see a point where a non-safe access can occur..but, shouldn't normally be accessed.

[AdrianD]

I'll check it out when I get back to the station.

Thank you sir for your time.

Reserved

[Uleat]

If you using older/custom code and don't want to update, check out this section I made changes to:
https://github.com/EQEmu/Server/blob...ket.cpp#L12235

Hopefully, your issue is bound to that snippet and the change will fix it, or at least stop the server from crashing.

If this does fix the crash and you are still having 'transaction' issues, post back any new results..otherwise, let me know
if this does fix it.

[AdrianD]

You hit the nail on the head.

I have been apprehensive to update the code due to all the changes I have done with my goal in mind. I understand my goal is not the goal of many/most who share the changes. I'm extremely grateful, regardless.

May of 2014 since I updated anything publicly. Nevertheless, I backed up everything and used SVN Update to update the Quests, Source and Source\utils\sql\git folders today.

I skimmed the changelog a few times to try and catch the optional and required changes which may cause issues with my altered database. I have some reservations but, that is not for this thread.

A lot has happened in a year!

*I haven't made any code changes. I don't have enough knowledge to attempt. I have changed the database quite a bit which includes removing "unnecessary" tables for a classic-like setting. Basically, I removed any table which appeared to not have a direct affect on a table I would keep for my purpose. I understand this is a bit naive and may explain some of the issues I am having. I get error logs for missing tables. It doesn't appear to affect gameplay.

QS and stacking: Ah, I failed to deduce that, thanks.

Age of code: no updates until today, since May 2014

Do you have 'RuleB(QueryServ, PlayerLogMerchantTransactions)' enabled?

Yes, QueryServ:MerchantLogTransactions is true for the ruleset used.

[Akkadius]

Sound advice is to pull code from the stable branch if you're concerned about stability and issues, it's exactly why we created it:

https://github.com/EQEmu/Server/tree/stable

PEQ and EZ clear the master branch and usually KLS and I will discuss if master should be pushed over to the stable branch after PEQ or EZ have been running on it for a week. Lately it has been KLS and PEQ making these judgment calls as I've not been aggressive with code updates or any projects for that matter this summer

[AdrianD]

Thanks for that.

[AdrianD]

I performed all the required sql updates and upon logging, no npcs spawned. It took a while to figure out and the issue was from the `12_24_14_npc_types_update.sql` update. An original programming typo, I'm guessing.

This was quite a while ago so I imagine this has been resolved although, if that were the case, I wouldn't have had the issue in the first place, right?

I saw the changes made but, for some reason I didn't get them.

Am I supposed to do anything after SVN Update? I updated the source, maps, quests and database through the queries.

Maybe you are thinking to yourself, "What a noob..." Well let me tell you something, I'm living it right now and it fucking sucks. I can't stand not getting shit done and my patience is waning. /rant off

Anyways, I'm still having the same issue with purchasing more of an existing partial stack. The same crash report was produced.

I noticed Uleat did some codework and I really appreciate it.

[Uleat]

Did the crash occur at the same line as the old log? (You updated, didn't you? That's probably not true any longer.)

If you did update, post the new crash log so I can see where the crash aligns with the newer code..if you would, please