Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

Reply
 
Thread Tools Display Modes
  #1  
Old 12-16-2008, 02:39 AM
EvoZak
Sarnak
 
Join Date: May 2008
Location: Midwest
Posts: 72
Default Couple of doors questions

#1 Looking at the doors code lately and I noticed something interesting. The Door_Struct has a uint8 typed for the doorId but the database (PEQ in this case) has doors with IDs past 255 (all in Mischief no less... hehe).

This may just be a database issue (doors table certainly doesn't restrict to byte sized ints) but there are no checks in the code on data length. Is it the system's default behavior for implicit casts to shave data without error? If that's the case it would explain why there is no errors being thrown.

#2 In the doors table the columns doorisopen and buffer seem to have no apparent use in the code anymore. Does anyone know of one, other than holding up the correct indexes for the code that fetches door data? What is/was buffer used for, in particular?
Reply With Quote
  #2  
Old 12-16-2008, 04:34 AM
KLS
Administrator
 
Join Date: Sep 2006
Posts: 1,348
Default

I honestly have no idea why some of the door code still functions as there some serious casting issues somewhere, I haven't taken the time to see where because it works for now.

The field was probably used to store whether a door was open or not at one point but obviously outlived it's usefulness.
Reply With Quote
  #3  
Old 12-16-2008, 06:52 PM
EvoZak
Sarnak
 
Join Date: May 2008
Location: Midwest
Posts: 72
Default

Thanks for the reply. Yeah, it looks to me like doorisopen and buffer are both vestigial.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 08:58 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3