Steam RoF2 Development Tracking

[trevius]

This thread was created to help keep track of the development of the Rain of Fear (version 2 - build date of May 10 2013 23:30:08) client. We are referring to this client as "RoF2" since it is still the RoF expansion, but is newer than the previous client. It is actually considered Shadows of Fear, which is a mini expansion that came via a patch, but we did not want to call it SoF2 (since SoF was already taken).

This Rain of Fear (RoF2) client is currently only obtainable via Steam.

This thread can be used as a reference for what needs work, and who is working on what. I will try to keep this post updated as people update the thread or make commits with any progress or notes.

This thread can be used for any development related work or concerns as well as to report any bugs with the client that haven't already been documented.

This thread will be focused on RoF2 specific bugs, not general bugs that exists in some or all other clients. Because we are already tracking known issues with previous clients in other threads, this thread will not repeat those same issues. For reference, see the following threads for previous client development tracking:
SoD Development Tracking
Underfoot Development Tracking
VoA Development Tracking
RoF Development Tracking


Last Updated - March 2nd 2015


Top Priority Work:
1. Guild Bank - The Guild Bank window opens, but deposit does not work. This is possibly just a slot issue that needs to be converted to the RoF slot system in the struct.


Medium Priority Work:
1. Bazaar - /bazaar searches do not function yet. This is due to several packet related changes in how bazaar is handled.


Low Priority Work:
1. Mend - The Monk Mend skill has random refresh timers after first logging in/zoning. This is most likely due to not passing a timestamp in the PP field for it.


Client Issues:
1. Many of the old world zones that were revamped have been removed from the client. This includes zones like commons, but we will need to get a full list of missing files together. The good news is the files can be added to the client folder and will work once they are there (similar to what needs to be done on the Underfoot client).
2. Due to Ornamentations using augment types 20 and 21, items cannot have both of these aug types at the same time. These slots appear large at the top of the item stat window and it can only display 1. If this causes a problem on any custom server, they should run SQL to convert type 20 and 21 to other slots on the items as well as augments (and inventory table).


Database and Source Code Changes that will be needed at some point:
1. Will need to convert the source and database to use the new Live format for item slots and to allow bags larger than 10 slots and the 2 new main inventory slots.
2. Will most likely need new Database and source changes to get the new /bazaar feature working in all zones (including bazaar itself).
3. RoF2 client does not automatically find the best Z location for ground spawn objects. This means that forges, bird baths, etc may need to be set to the correct Z location in the Database if they show as hovering.


New Systems to RoF2 that did not exist in Underfoot (that may/does require code support):
Note that many of these were carried over from the work on the RoF and VoA clients, so they need to be validated.
1. Containers can go above 10 slots and it looks like the max is at least 32 slots (though there is no reason for hard setting a max in the source with the new slot format). I tested a 100 slot bag and it worked.
2. Two new slots in the base player inventory for a total of 10 (restricted to 8 in the source for non-GM characters).
3. Merchant window now has a "Reclaim" tab. Any item you destroy during a single session of EQ (Unsure if it resets when you log) is shown in this tab and can be purchased at the cost of "Reclamation Tokens"
4. /bazaar is now searchable from all zones and you can buy/sell directly from that window and items can sell even while you are offline.
5. Item Hotkeys - The new Item Hotkey always shows the item in the Charm slot due to an issue with how item headers are serialized now. This is a new feature in addition to the old slot based hotkeys.
6. Augmentations - Augments can now be right clicked to allow them to be deleted directly from the slot without removing them, and can also be swapped without removing first. This is not yet implemented in EQEmu.
7. Guild Permissions/Ranks - There are now 8 guild ranks and each rank can have several different permissions defined for them. This would require a major overhaul to the guild management code.


Special Client Notes:
Item Hotkeys - Slot based hotkeys can still be created by holding ALT+Click on a slot. The new item-based hotkeys are created by holding left Click.


Recently Resolved Issues:
1. Empty Containers can be stored inside other containers. This is now supported!
2. Death - Reports that dying was not causing the client to zone. This was resolved by correcting the opcodes.
3. Ebon/Radiant Crystals - The totals for these did not show correctly until after you use them. This was resolved by aligning the PP.
4. Leadership AAs - The Leadership AA window did not display totals correctly. This was resolved by aligning the PP.
5. Adventure Stats - The Adventure Stats window did not display totals correctly. This was resolved by aligning the PP.
6. Logging in or Zoning Times - It was taking about 2 minutes to login/zone due to an issue that causes the client to search for a boat that does not exist. This was resolved by aligning the PP.
7. Leadership AAs - Purchasing Leadership AAs did not work. This was resolved by correcting the opcodes.
8. Recipe Searches - This did not work. This was resolved by correcting the opcodes.
9. Corpses - Corpses now show items on them again. Was broken when Client62 was removed, but has been resolved.
10. Alternate Currency Merchants - Alternate Currency Merchant buying and selling are both now functional. Structs were corrected.
11. 6th Aug Slot - Aug slots now go up to 6 max instead of the previous 5 max. Source updated to implement 6th aug slot.
12. Rest Timer, Show Helm Option, Auto-Consent Options - All fixed by correcting the Player Profile packet.
13. Resurrection - Resurrection is now fixed. There were 4 bytes added to the response struct.
14. Tracking - Tracking Window now displays correctly and track now works. Struct and opcode corrections made.
15. Cursor Buffer - This should now be working like previous clients. Had to add a work-around to handle it until the new slot system is in place.
16. Dropping Items - Dropping items now go to ground level instead of camera-height level.
17. Caster Augmenting - Cloth Armor was unable to accept type 8 (and possibly other types) augs. This has been resolved by identifying the item packet field causing it.
18. Aug Slot Type 21 - Items with Slot 21 for augs had Buy Now button instead of a slot. This was related to the Membership packets and has been fixed.
19. Looting - NPC Corpses with more than 10 items on it was not functional. This was corrected by sending the correct slot types for corpses on RoF2.
20. Looting - Sometimes the incorrect item would get looted due to slots being in the wrong order. This was corrected with the same fix as above.
21. Shielding and Key Ring - /shield (shielding) and /key (key ring) are both now functional after opcode updates.
22. Pet focus and hold - The /pet focus on/off and /pet hold on/off commands are now functional. This was an issue with the defines and case switch for the commands.
23. Guild Rank - Promote is now functional, new members are now members instead of recruits, and /guild chat works properly for new members.
24. Environment Damage - This is not functioning properly (falling, lava, etc damage). This was corrected by adjusting the struct size.
25. Item Hotkeys - The new Item Hotkeys which are created by holding Click on an item are now functional. This was resolved by adjusting the unique string length.
26. Guild Alts - Setting Guild Members as Alts in the Guild Management Window now saves and is functional for filtering. It was resolved by correcting the opcode.
27. Cross-Client Guild Invites - Guild between RoF+ and previous clients now works. Temporary work-around was added to convert the membership rank of invites/accepts.
28. Shared Platinum - Platinum put in the Shared Bank was not being displayed after relogging. This was corrected by identifying the field in the PP.
29. Bandolier - The Bandolier was displaying a treasure chest icon (836) when nothing is set in it. Had to set icon to -1 instead of 0 in the PP.
30. Discipline Updates - Disciplines were not updating when scribing a disc from a Tomb. Corrected by changing max disciplines from 200 up to 300.
31. Bazaar Trader - Buying and Selling from Bazaar Traders is now functional.
32. Bard Effects - The effects for songs on Bard Items was not displaying. This was corrected by updating the Encode to include Bard Effects.


Attaining the Steam F2P (Free to Play) RoF2 Client:
http://store.steampowered.com/app/205710/ - Note: Do not purchase the latest expansion on Steam as it is the same Download as the F2P one.
Click the "Play Game" button.
If you have Steam, you will be given the option to open it up in Steam and you can download it from there. If you do not have Steam installed, you will have the option to install it. Install it and then get the client from within Steam.
Once the client is downloaded, move the Everquest F2P folder (something like "C:\Program Files\Steam\SteamApps\EverQuest") to another location so it doesn't get patched by Steam at any point. Make sure not to start the client using the installed desktop icons. You do NOT want to patch the client to Live!
Then just follow the normal EQEmu client setup instructions to change the eqhosts.txt file and create the shortcut using the patchme argument.

This post will be updated again regularly with current development status. Devs, please feel free to edit this post as needed.