Bugs

KingMort · #1 01-04-2008, 08:10 PM

Bards are STILL crashing zones with their songs I haven't seen much done to fix this..

Also wanted you guys to be aware of another bug

Some characters suddenly are un-able to receive a rez.. The rez lands but nothing happens, then they can't rez again because already been rezzed...

RANDOM however most people are un-effected , but some folks get this bug... What is it that causes someone to never be able to rez again ?

**KLS** · #2 01-05-2008, 08:17 AM

Haven't been able to crash a zone with bard songs, will need more info.

**cavedude** · #3 01-05-2008, 08:54 AM

TGC hasn't had many, but here is the dump from one:

Code:

#0  0x080f348b in Mob::BardPulse(unsigned short, Mob*) (this=0x0,
    spell_id=723, caster=0x43a4c928) at spells.cpp:1575
#1  0x0810d0d7 in Group::GroupBardPulse(Mob*, unsigned short) (
    this=0x43a26d68, caster=0x43a4c928, spell_id=723) at groups.cpp:505
#2  0x080f338f in Mob::ApplyNextBardPulse(unsigned short, Mob*, unsigned short)
    (this=0x43a4c928, spell_id=723, spell_target=0x43a4c928, slot=7)
    at spells.cpp:1551
#3  0x080d2fdd in Client::Process() (this=0x43a4c928) at client_process.cpp:163
#4  0x080ba33f in EntityList::MobProcess() (this=0x82901c0) at entity.cpp:442
#5  0x080de70d in main (argc=0, argv=0xbfffe994) at net.cpp:479

**KLS** · #4 01-09-2008, 08:15 AM

I'll look into possible crashes in the bard code but until I can have some situation that causes it, like a certain spell that will always cause a zone to crash I'll be shooting in the dark.

**Derision** · #5 01-09-2008, 09:36 AM

From Cavedude's backtrace, it looks like maybe it has something to do with pets, in this code around line 505 in groups.cpp:

Code:

#ifdef GROUP_BUFF_PETS
                                if(members[z]->HasPet())
                                        members[z]->GetPet()->BardPulse(spell_id, caster);
#endif

Maybe getting a NULL pointer from GetPet() ? (this=0x0 in Mob::BardPulse in Cavedude's BT)

Could try checking if GetPet() returns NULL which may stop the crashes (although not fix the root cause):

Code:

#ifdef GROUP_BUFF_PETS
                                if(members[z]->HasPet()) {
                                        Mob* tmppet;
                                        tmppet = members[z]->GetPet();
                                        if(tmppet != NULL) tmppet->BardPulse(spell_id, caster);
                                }
#endif

I've not tried to reproduce this or anything, just throwing this out there as a possible avenue of investigation.

**KLS** · #6 01-09-2008, 01:40 PM

That's actually an issue, haspet doesn't return whether or not getpet returns a valid pointer in every case.

KingMort · #7 01-12-2008, 09:17 AM

Lots of bard songs cause the crash and usually gives about the same core dump..

**Derision** · #8 01-12-2008, 09:27 AM

Quote:

Originally Posted by KingMort

Lots of bard songs cause the crash and usually gives about the same core dump..

Do you know if there is always a bard grouped with a player that has a pet when the crashes occur ?