Fix for bald players bug

[kraeger]

Angelox is right, it's not my fix that is in the code. I was quite happy to see that a better code had been written, but i will be honest, i am a bit sad after seeing that my name is not in the changelog, at least as part of the team that helped solve the problem, i spent 25+ hours working on this bug..

Anyway:

haircolor 255 = white hairs (when working correctly)
haircolor 0 = dark brown hairs (when working correctly)

I haven't tried 1120 and i don't know what the new fix is in the code, but this what i can understand from what So_1337 is seeing in game:

My fix only affected player characters, this is why we didn't see a change on NPC. From what i understand, the new fix is working on both player and NPC, so we would either need to know what kind of characters it's drawing (Player or NPC) or we would need to update the default NPC model to have brown hair (after the fix).

[So_1337]

I had no idea, my apologies. I saw your fix here and the reports that it was working, then saw that 1120 included a fix for bald players and assumed it to be yours.

Guess we'll have to wait for the full story from KLS. Thanks for the information, guys.

[KLS]

Yeah I'm sorry, but none of your code was used for the fix, I'm not even sure if it's a full fix atm. But you were the inspiration behind it, I'll add you to the log on next update if you'd like.

[kraeger]

None of my code was used so i don't deserve any credit? Well that is kind of rude.

A problem is around for 2-3 years. I find the bug. I write a code that 100% fix it. People test it and it's working. No more bug.

Two days later, a dev comes around and rewrite my code, fixing the same bug but in a different way. (Using all the info i gathered (i said exactly what was not working), taking notes on how i fixed the bug but not using my code, he write his own code.)
The dev code ends up in 1120:
-Breaking all npcs hair colors, they all have white hairs now (my code solved that problem)
-You can't pick the dark brown hair color, it turns white (my code solved that problem)
-You can't pick one beard model, one face model and one eyecolor (my code solved that problem)

Then, he tells me that i don't deserve any credit for "fixing this bug", since none of my code was used. He also tell me that all i was is the inspiration that helped him make his new amazing improved piece of code. Finally, he says that i can have my name written in the next changelog if that can make me happy.. so i shup up and stop talking about it.

If anyone want to say that this is drama, that i am overreacting, that i'm just crying, go ahead.. this is what i'm doing. But right after you post, please re-read what i wrote and ask yourself if i have any reason to feel that way.

Can i remind that dev that right now, i am the only one who made a working fix for this problem.. and i don't deserve any credit?

Is this how things work here?

*Btw, don't add my name to the changelog. I won't be posting on this forum anymore, don't worry.

[trevius]

Part of the changelog is to give credit to whoever's code goes into the source and another part is probably to help keep track of what was done by who for tracking purposes.

It sounds like your fix might have worked just as good or better than what went into the 1120 source (I haven't tested it yet). But, I am also very sure that KLS didn't use your source changes for a reason. She is a very skilled coder and she makes sure that anything that goes into the source is as complete as possible. It is very rare that something that is incomplete makes it into the source (I am not saying your fix was incomplete).

If she thought it was necessary to rewrite everything you had already done from scratch, then I am sure she had a good reason. Though, I do think that your name deserves to at least be mentioned in the change log since you did a lot of the foot work for it as well as being the first person to even attempt to fix it after all of this time that the bug has been submitted.

Please keep in mind that while you are the one that made the original fix, that it apparently isn't at all the same as what went into the code. So, technically there is nothing wrong with your name not being in there. I am sure KLS only left your name out because the actual code was her own, so for tracking purposes your name shouldn't be there accept possibly noted as inspiration for the real code.

I do see that your name was put in there for the Random Name Generator Fix. So, it isn't like the team is trying to take credit for other people's fixes.

There is a lot going on with this project and everyone works on it in their own free time for free. Occasionally some code won't get the right credit in the change log (which is fairly rare), and sometimes code even gets forgotten and never makes it in when it really should have. I have been trying to help keep things organized so that we don't lose any good fixes. But, again there is a lot going on and it is hard for some people to keep up with every little thing that gets posted on these forums. I have more free time for it than most do, and that is why I try to do what I can.

What I am trying to say is that I don't want you to get the wrong impression about how this project and team works. We all have real lives to deal with and all have busy schedules. Mistakes will be made due to limited resources. The team would never intentionally take credit for someone else's work. KLS has never been anything but nice and helpful to this project and everyone involved.

I think you are just having a misunderstanding of the situation and so I hope that I have cleared some of it up. The entire community is thankful to anyone who spends time fixing bugs and adding new additions for the source. I personally appreciate the work you have done so far quite a bit. And, I honestly hope you will reconsider your view on the project and on these forums.

This project is about the community though. So, if you are just posting code fixes to get your name in the change log, then you are posting them for the wrong reasons, IMO. I do what I do just to help people. And, by doing so, I have a fairly good reputation. I wish the project could be slightly more organized and give everyone credits and rewards for everything they help out with, but this site does receive a considerable amount of traffic. Though, if you are able to be a consistent positive member of the community, you will certain be able to make a name for yourself if that is what you want.

Thanks again for your code fixes. I hope you reconsider continuing to post them here.

[KLS]

Well I couldn't really see fit to defend myself without sounding like a jerk so thank you Trev.

Over-reacting just a bit I think.

Anyway I'm going to be undoing my fix anyway as it was only experimental. I'm going to review the code you posted to get a better idea of what is wrong. That said the reason your code isn't going in as is is because it's a workaround which I try to avoid whenever possible; ie it's better to fix the issue than bandaid it. If it's fixed via what's I just said you will get credit as a derived work.

I wasn't trying to hurt your feelings, I promise.

[So_1337]

I had a long post typed up, but I honestly feel I'm in over my head here. I don't know the code well enough to speak on it.

To put it simply, though, the ends are just as important as the means when it comes to fixes around here. You solved the problem and gave Kim a great idea of how to fix it herself without the need for a work-around. I'm sure if she wasn't so strapped for time, she would've communicated it better, as she's never been anything but courteous and respectful. We're lucky to see as much work from her as we do, I reckon =)

Take a deep breath, and relax. This is a group project, and it sure isn't over. Plenty of time to get everything ironed out, be it proper credit in the changelog or a fix that not only solves the problem, but does it in a way consistent with the rest of the code.

Would really love to see you continue your work here.

[Angelox]

I saw this one coming right after I diff'd the update -
Put kraegers fix in, then, when you make a better fix, take his out, put yours in! Meantime, people get a bald players fix, kraeger gets his earned recognition, and everyone is happy.
Regardless of what you think, people need recognition for their work - you all have your titles and colored names, and that's recognition for your work!