EQOffline:BotCount issue I think

[Derision]

It's not actually your fault, it is a problem with the makefiles.

Both the makefile.common for world and zone specify ../common/rulesys.o in the SF= line.

../common/rulesys.o gets compiled for world first, then, when zone gets compiled, it sees that ../common/rulesys.o is newer than ../common/rulesys.cpp and so it knows it doesn't need to recompile it.

Normally, this is not a problem, however in the case of code bracketed in #ifdef/#endif, where different defines are used between world and zone, it causes problems.

Instead of ../common/rulesys.o, the world and zone makefile.common should specify .obj/rulesys.o

This tells the makefile to compile it's own private version using it's own set of -D flags.

I'll update the makefiles.

The EQOffline:BotCount rule should really be a RULE_INT (integer) rather than a RULE_REAL (floating point).

[cubber]

Thanks for the clarification Derision.

[Angelox]

Originally Posted by Derision

The EQOffline:BotCount rule should really be a RULE_INT (integer) rather than a RULE_REAL (floating point).

I'll get this fixed - I just at first didn't have any makefiles for with the WORLD makefile, and was going crazy trying everything, tell I realized what it was.

I've been trying to post replies on these forums, but for seems it goes dead at night for hours and now seems to drop a lot during the day too. Last night I couldn't get on here to reply, finally I just went to bed.

[Angelox]

Derision; I also noticed, it seemed at one time, when I did a 'make clean' from the source root, it would go through all the subs and include a 'make depend' , it doesn't seem to do that anymore, just includes 'make clean' only.
I wonder if something got removed?

Originally Posted by Derision

It's not actually your fault, it is a problem with the makefiles.

Both the makefile.common for world and zone specify ../common/rulesys.o in the SF= line.

../common/rulesys.o gets compiled for world first, then, when zone gets compiled, it sees that ../common/rulesys.o is newer than ../common/rulesys.cpp and so it knows it doesn't need to recompile it.

Normally, this is not a problem, however in the case of code bracketed in #ifdef/#endif, where different defines are used between world and zone, it causes problems.

Instead of ../common/rulesys.o, the world and zone makefile.common should specify .obj/rulesys.o

This tells the makefile to compile it's own private version using it's own set of -D flags.

I'll update the makefiles.

[Derision]

Originally Posted by Angelox

Derision; I also noticed, it seemed at one time, when I did a 'make clean' from the source root, it would go through all the subs and include a 'make depend' , it doesn't seem to do that anymore, just includes 'make clean' only.
I wonder if something got removed?

I don't know. The oldest source I have readily to hand on my Linux server is 0.7.0-1035 and it seems to exhibit the same behaviour as the current makefiles.

[Angelox]

I just started to make this post pointing out it was working in EQEmu-0.7.0-1129, but not now, and I saw why it doesn't work;
when someone uploaded the source to SVN, they also uploaded their .depend files , the makefile checks to see if there is .depend files, if not it will auto make them. So, you can quickly run a 'make clean' from the root, all that will happen and new custom .depend files are created. If there already are .depend files, then you have to force a 'make depend' in each directory.

Originally Posted by Derision

I don't know. The oldest source I have readily to hand on my Linux server is 0.7.0-1035 and it seems to exhibit the same behaviour as the current makefiles.

EDIT:
That problem was me, I must have at one time run 'make clean' in my local SVN , and it created the .depend files - since it's on another PC with another version of my distro, it made the problems for me. I deleted the .depend files from SVN, it works again.

[Kaain]

Hmm... been trolling around here and ProjectEQ for a couple of days looking for other reports of this. I have the same issue after upgrading my server from Revision245-Bots to the compiled version CD posted on code.google.com that is Revision279-Bots.zip. When starting the server World ERRORS on the following:
[01.22. - 20:27:33] [RULES__ERROR] Unable to find rule 'EQOffline:BotManaRegen'
[01.22. - 20:27:33] [RULES__ERROR] Unable to interpret rule record for EQOffline:BotManaRegen
[01.22. - 20:27:33] [RULES__ERROR] Unable to find rule 'EQOffline:BotFinishBuffing'
[01.22. - 20:27:33] [RULES__ERROR] Unable to interpret rule record for EQOffline:BotFinishBuffing
[01.22. - 20:27:33] [RULES__ERROR] Unable to find rule 'EQOffline:BotCount'
[01.22. - 20:27:33] [RULES__ERROR] Unable to interpret rule record for EQOffline:BotCount

After logging my player in, I cannot spawn any bots so in my case the BotCount must default to 0.

I can see the rules in the rule_values table, bot records in the bot tables and even completely dropped my db and reinstalled from scratch and then restored my account table from a recent backup. I'm thinking the problem isn't database but the compiled exe's from Revision279-Bots.

Is it possible the issue discussed in this thread could by my problem if CD compiled from the same source?

[Angelox]

Appears the compile was made with the bot/ makefiles left out. You can go to my Site and download the executables I have posted, see if it works better , mine are 276, will be 279 this weekend (haven't had time for the 279 executable compile).

[Kaain]

Thank you Angelox! Your exe's seem to have done the trick. No more world errors. I'll bring the exe's up to date whenever new ones are available since I don't have compile capabilities. Maybe I won't need a new keyboard now that I have stopped bashing my forehead into it

Kudos to all the excellent work you guys have done on the bots system. The main reason I updated.