A HUGE bug with quest::modifynpcstat

[KLS]

mmm I haven't experienced this but I'll take a look, I wanted to change/fiddle with some of the commands anyway.

[ChaosSlayerZ]

oh KLS btw I posted some new data on players fake hp buffs at Storm Heaven forums in that thread.

[Shendare]

Fiddle with them all you like. Just don't banjo with them. *shudder*

[So_1337]

Well that was a great laugh to start the day off =)

[ChaosSlayerZ]

Here is a little update.

I tried to go around quest::modifynpcstat(); and set hps directly with

$npc->SetHP(); and $npc->SetMaxHP();
(also tried using mob-> with same result)

with this simple script

sub EVENT_SAY 
{ 	
	if($text=~/Hail/i)
	{	

             $npc->SetMaxHP(9999);	
	$npc->SetHP(9999);

	my $hps=$npc->GetHP();	
	my $maxhps=$npc->GetMaxHP();	

	quest::say("my hp is $hps  out of $maxhps"); 

	}
}

Results:

-if script contains: $npc->SetMaxHP(); the cript will NOT run - the npc will not reply to Hail at all.

-if script contains ONLY $npc->SetHP(); the ncp will reply to hail but comand WILL NOT have effect- his hps will remain an altered (default)

[trevius]

Using $mob instead of $npc should work just fine for the HP setting quest objects.

[ChaosSlayerZ]

I have just tried it- the script won't run at all - the npc won't even reply to hail

[trevius]

Ahh, I guess it is $npc after all. Maybe I was thinking of what it shows in the wiki as an example for using that object. Here is an example of one of the quests for SH that use SetHP and it definitely works without any bugs:

$npc->SetHP($hp_increase);

The $hp_increase variable in this case is just something we use for calculating how much to heal the NPC for when certain things happen. That should be replaced with the amount of Current (not max) HPs you want the NPC to have. So, if your NPC has a max of 1000 hps, you could set it to half health by doing:

$npc->SetHP(500);

[realityincarnate]

The problem with the last script is that SetMaxHP doesn't do what you think it does. It doesn't take any arguments, and just sets the current hp to max. SetHP() seems to work fine, but it won't allow values higher than the max hp.

Of course, none of this solves your real problem, but it's all I know for sure while I'm sitting at work bored.

[Shendare]

Ahh, so npc->SetMaxHP() is basically a way of saying npc->SetHPToMax().