New Rule: Flagging Hostile NPCs

[Shendare]

Right, and pets generally con as indifferent anyway, which would prevent them from ever getting to the tagging portion, which only activates for Glares Threateningly or Ready to Attack.

[Kobaz]

Testing with an otherwise stock server, this change does indeed stop pets being raised. It's a shame, as it's the kind of thing that would make the game more friendly for very young players.

[Shendare]

Roger that.

I'll have to take a deeper look to figure out what could possibly be going wrong with such a simple little piece of code.

[Shendare]

Okay, apparently the problem was caused by a call to GetReverseFactionCon() for a non-player entity.

Fixed with the following code change:

File: mob.cpp, Line 817 - mob::FillSpawnStruct()

  if (ForWho && ForWho->IsClient() && RuleB(World, FlagHostileNPCs))
  {
    switch (ForWho->CastToClient()->GetReverseFactionCon(this))
    {
      case FACTION_THREATENLY:
      case FACTION_SCOWLS:
        memcpy_s(ns->spawn.lastName, sizeof(ns->spawn.lastName), "Hostile", 8);
        break;
    }
  }

On an unrelated note, I found that if you have a pet, you can aggro hostile NPCs even with the GM flag on. LOL.

It's hard to tell whether the pet's aggroing the NPC or the NPC is aggroing on the pet.

[ChaosSlayerZ]

hmm thats bad. I remember when back on the day your pet shared your faction - it was a nightmare. Since my pet was always lower level than my necro I could not just walk through a dungeon where mobs were allreday green - I had to kill every darn thing cuase it kept agroing on my pet.

But back in 2001 they finaly made it so your pet does not have a faction at all, so mobs never agro on the pet. So once mobs are green, you can walk around with lev 1 pet totaly safe

[Shendare]

Apparently we could use the same change.

I just did some testing, and while a grey-con Level 40 hostile NPC will not attack a Level 75 character, it will attack its Level 2 pet, and then turn to the owner once the pet is dead.

Guard Legver glares at you threateningly -- You could probably win this fight.
Guard Legver hits Zarartik for 120 points of damage.
Zarartik has been slain by Guard Legver!
Guard Legver tries to hit YOU, but misses!
Zarartik tells you, 'Attacking Guard Legver Master.'
Guard Legver bashes YOU for 33 points of damage.

Also, pets can speak from beyond the grave. OooooOOOOOoooooh. Heh heh.

[ChaosSlayerZ]

hehe, but yeah this was a huge annoyance on LIVE, we realy need to get rid of it =P