COMMITTED: Suspend Minion Patch

**Derision** · #1 01-18-2010, 03:31 PM

I'll get to it, probably at the weekend when I have more time to test it, unless another Dev has time to do it before then.

**KLS** · #2 01-18-2010, 04:38 PM

Code:

//WIP -- brandon

I know you see names in comments all over the code but please don't add any more. They don't really add anything and are basically graffiti inside the code.

I'm taking them out where I can find them, and if I ever get around to posting code standards no names will be in there.

Other than that I think it's to the acceptable point now.

**Derision** · #3 01-19-2010, 02:00 PM

I've committed this in Rev1123.

I put the SuspendedMinion struct into the Player Profile, and also implemented Persistent Minion as it was a simple two line addition to do so.

There was an existing method, EntityList::Fighting which appeared to have the same functionality as your HasAggro method, so I used this.

Most of the other changes I made were purely cosmetic.

I tested it using a Necro ... let me know if I broke anything in the process of committing it.

Finally, nice work, thanks for the contribution, I'm sure the classes who can use this AA will appreciate it.