Zone crashes when mob dies to dot

Caryatis · #1 08-15-2010, 01:06 AM

Thought it was just me but tried it on a fresh source(1623) and still happened.

Caryatis · #2 08-15-2010, 02:55 AM

Seems to be caused by the new perm buff code as it only happens in zones with that enabled.

**Derision** · #3 08-15-2010, 05:47 AM

This should fix it:

Code:

Index: spdat.cpp
===================================================================
--- spdat.cpp   (revision 1621)
+++ spdat.cpp   (working copy)
@@ -216,7 +216,9 @@

 bool IsBeneficialSpell(int16 spell_id)
 {
-       // EverHood - These spells are actually detrimental
+       if(!IsValidSpell(spell_id))
+               return false;
+
        if(spells[spell_id].goodEffect == 1){
                SpellTargetType tt = spells[spell_id].targettype;
                if(tt != ST_Self || tt != ST_Pet){

I'll commit it to the SVN later on.