Odd bug with Damage(from, damage, spell_id, attack_skill, avoidable= true, buffslot=

[Derision]

This is what appears to be happening in Trevius' example:

If you call Damage from Perl, when:

	parse->Event(EVENT_HP, GetNPCTypeID(), 0, CastToNPC(), NULL);

is called from void Mob::CreateHPPacket(EQApplicationPacket* app), it gets to this point:

void PerlembParser::EventCommon(QuestEventID event, int32 objid, const char * data, NPC* npcmob, ItemInst* iteminst, Mob* mob, int32 extradata)
{
        if(!perl)
                return;

        if(event >= _LargestEventID)
                return;

        if(perl->InUse()) {

and since 'Perl is in use', executing the EVENT_SAY, the EVENT_HP is queued until the EVENT_SAY completes, therefore SetNextHPEvent is also not yet executed which means
lasthpevent == nexthpevent in the test in CreateHPPacket, leading to SetNextHPEvent(-1) being called.

As I say, the EVENT_HP is queued and should execute (along with any other queued EVENTs) once the EVENT_SAY in this example has finished.

[trevius]

Thanks Derision! I think that makes the most sense of anything I have seen yet. I was thinking EVENT_HP could probably have been coded better anyway, so maybe I will think on it a bit and see if I can figure out a better solution. I thought it seemed odd that the code for it would rely on a value that was supposed to be changed by perl during the function. If you are correct, probably other servers are getting bugged events that use EVENT_HP sometimes and maybe not realizing this is the cause. We use it in quite a few events on Storm Haven and some of those are out buggiest events. It would be awesome if a rewrite of how EVENT_HP is handled could resolve the random events bugs we have seen.

[trevius]

Thanks to Derision finding the cause of the issue, I was able to get it fixed and it is in Rev1715 on the SVN now