Mounted Out of Combat Regeneration

[Sikkun]

So I did more testing with this and the only problem I can find with this solution is that you still gain rested OOC while moving on a mount.

If anyone could point out were the code for movement is im sure just adding a playeraction = 0 when movement would fix that.

Or another thought I can not find the code that controles the resting UI. If I knew were that was I see no reason why something like...

if(restui == true)
{
playeraction = 1;
}
else
playeraction = 2

wouldn't fix the entire mounted ooc problem

Sikkun

[Sikkun]

Ok so I have came out with a new solution. This works when sitting and standing still on a mount, it no longer allows you to regenerate while moving on a mount.

in the Zone project
client_process.cpp
void Client::Handle_OP_ClientUpdate(const EQApplicationPacket *app)
Method

ADD:

//allow player to have OOC regeneration on a mount
	if(ppu->y_pos == y_pos || ppu->x_pos == x_pos)
	{
		if(GetHorseId() != 0)
		{
			playeraction = 1;
		}
	}
	else if(ppu->y_pos != y_pos || ppu->x_pos != x_pos)
	{
		if(GetHorseId() != 0)
		{
			playeraction = 0;
		}
	}

I added my code right after the //Break hide if moving without sneak code block so it looks like:

// Break Hide if moving without sneaking and set rewind timer if moved
	if(ppu->y_pos != y_pos || ppu->x_pos != x_pos){
	    if((hidden || improved_hidden) && !sneaking){
			hidden = false;
			improved_hidden = false;
			if(!invisible) {
				EQApplicationPacket* outapp = new EQApplicationPacket(OP_SpawnAppearance, sizeof(SpawnAppearance_Struct));
				SpawnAppearance_Struct* sa_out = (SpawnAppearance_Struct*)outapp->pBuffer;
				sa_out->spawn_id = GetID();
				sa_out->type = 0x03;
				sa_out->parameter = 0;
				entity_list.QueueClients(this, outapp, true);
				safe_delete(outapp);
			}
		}
		rewind_timer.Start(30000, true);
	}

	//allow player to have OOC regeneration on a mount
	if(ppu->y_pos == y_pos || ppu->x_pos == x_pos)
	{
		if(GetHorseId() != 0)
		{
			playeraction = 1;
		}
	}
	else if(ppu->y_pos != y_pos || ppu->x_pos != x_pos)
	{
		if(GetHorseId() != 0)
		{
			playeraction = 0;
		}
	}

[Sikkun]

Make client_process.cpp
client_packet.cpp

[lerxst2112]

Hmm, forcing them to sitting seems like the wrong approach to me. You know they're on a horse, so I think something like this might be better. I haven't tested it, but I think the logic is correct. It works the same as mana regen when sitting or mounted as seen in Client::CalcManaRegen() and Client::CalcBaseManaRegen().

client_process.cpp

void Client::CalcRestState() {

	// This method calculates rest state HP and mana regeneration.
	// The client must have been out of combat for RuleI(Character, RestRegenTimeToActivate) seconds,
	// must be sitting down or mounted, and must not have any detrimental spells affecting them.
	//
	if(!RuleI(Character, RestRegenPercent))
		return;

	RestRegenHP = RestRegenMana = RestRegenEndurance = 0;

        if(AggroCount || !IsSitting() || !GetHorseId())
		return;

[sorvani]

Originally Posted by lerxst2112

client_process.cpp

void Client::CalcRestState() {

	// This method calculates rest state HP and mana regeneration.
	// The client must have been out of combat for RuleI(Character, RestRegenTimeToActivate) seconds,
	// must be sitting down or mounted, and must not have any detrimental spells affecting them.
	//
	if(!RuleI(Character, RestRegenPercent))
		return;

	RestRegenHP = RestRegenMana = RestRegenEndurance = 0;

        if(AggroCount || !IsSitting() || !GetHorseId())
		return;

IsSitting will be FALSE if GetHorseID = TRUE so the ! will cause it to still do what it was doing before, return if you are not sitting. Should it be more like:

        if(AggroCount || !(IsSitting() || GetHorseId()) )