Item stacksize

[lerxst2112]

Some of the things you changed wouldn't have anything to do with this issue, specifically the "where to look" params. Presumably it won't hurt anything to have changed them.

Changing the quantities on those functions is a start, but you need to look at where they are called as well. As an example,

bool Client::DecreaseByID(int32 type, int8 amt)

has the potential to cause issues, although it is only called from Perl, and I didn't dig through any quest scripts to see if it is even used.

If you are able to narrow down specifically what you do to cause the problem it would probably help to narrow it down where in the code it might be occurring.

[blackdragonsdg]

I am not exactly an expert with C++ so some of the changes I made were purely a guess. Obviously I may have guessed wrong on somethings but it didn't hurt to try.
Today I focused on this error instead of trying to actually play EQ which was the case at the time I made my initial post on this issue. It didn't take long to find a trigger which allowed me to cause the error at will. The trigger is very simple...put an arrow on a merchant...set its stacksize to 1000 then purchase 1000 of them. When the purchased item is placed into the characters inventory automatically the stacksize is reduced to 232.

[lerxst2112]

Try changing this:

struct Merchant_Sell_Struct {
/*000*/    int32 npcid;			// Merchant NPC's entity id
/*004*/    int32 playerid;		// Player's entity id
/*008*/    int32 itemslot;
           int32 unknown12;
/*016*/    int8  quantity;		// Already sold
/*017*/    int8  Unknown016[3];
/*020*/    int32 price;
};

To this:

struct Merchant_Sell_Struct {
/*000*/    int32 npcid;			// Merchant NPC's entity id
/*004*/    int32 playerid;		// Player's entity id
/*008*/    int32 itemslot;
           int32 unknown12;
/*016*/    int32 quantity;		// Already sold
/*020*/    int32 price;
};

That might actually break something, but cross your fingers and prepare to change it back.

[blackdragonsdg]

Originally Posted by lerxst2112

Try changing this:

struct Merchant_Sell_Struct {
/*000*/    int32 npcid;			// Merchant NPC's entity id
/*004*/    int32 playerid;		// Player's entity id
/*008*/    int32 itemslot;
           int32 unknown12;
/*016*/    int8  quantity;		// Already sold
/*017*/    int8  Unknown016[3];
/*020*/    int32 price;
};

To this:

struct Merchant_Sell_Struct {
/*000*/    int32 npcid;			// Merchant NPC's entity id
/*004*/    int32 playerid;		// Player's entity id
/*008*/    int32 itemslot;
           int32 unknown12;
/*016*/    int32 quantity;		// Already sold
/*020*/    int32 price;
};

That might actually break something, but cross your fingers and prepare to change it back.

This did not fix the problem but at the same time it didn't appear to break anything either.
Maybe this will help narrow it down further and I just tried this.....I can summon stacks of 1000 random arrows and they can be placed into my inventory with no problem. I can manipulate those stacks without any reverting issues. I tried this with three different item id's of the same arrow name and type.