COMMITTED: Bot dyes (and tweaks)

[Taurinus2]

uint32 Bot::GetEquipmentColor(int8 material_slot) const
{
	//Bot tints
	int32 slotid = 0;
	uint32 returncolor = 0;
	uint32 botid = this->GetBotID();
	
	//Translate code slot # to DB slot #
	slotid = Inventory::CalcSlotFromMaterial(material_slot);

	//read from db
	char* Query = 0;
	MYSQL_RES* DatasetResult;
	MYSQL_ROW DataRow;
	
	if(database.RunQuery(Query, MakeAnyLenString(&Query, "SELECT color FROM botinventory WHERE BotID = %u AND SlotID = %u", botid, slotid), 0, &DatasetResult)) {
		if(mysql_num_rows(DatasetResult) == 1) {
			DataRow = mysql_fetch_row(DatasetResult);
			if(DataRow)
				returncolor = atoul(DataRow[0]); //atoi used here is wrong
		}
		mysql_free_result(DatasetResult);
		safe_delete_array(Query);
	}
	return returncolor;
}

See code and comment for details.

[Taurinus2]

Some explanation:

What is happening is that the color of the armor is not being preserved when it is given to a bot. Everything ends up being without color.

Some pics to illustrate:

before:



after:



For reference, the bot is wearing Kizrak's armor.

With this change, the color shall be correctly preserved and the slots can still be tinted to your heart's desire.