Client-Server Item Desyncronization Bugs

[Uleat]

I'm not sure what's going on with this code snippet, but I can't seem to get it to work properly when I add it to another function.

This code is copied directly from inventory.cpp::Client:eleteItemInInventory. It handles client updates when deleting partial quantity from current stack charges.

// Stackable, arrows, etc ? Delete one from the stack
	outapp = new EQApplicationPacket(OP_DeleteItem, sizeof(MoveItem_Struct));

	DeleteItem_Struct* delitem	= (DeleteItem_Struct*)outapp->pBuffer;
	delitem->from_slot		= slot_id;
	delitem->to_slot		= 0xFFFFFFFF;
	delitem->number_in_stack	= 0xFFFFFFFF;
	for(int loop=0;loop<quantity;loop++)
		QueuePacket(outapp);
	safe_delete(outapp);

I've adapted it to my needs, but what is happening is the client deletes the entire stack from the cursor, then each iteration
after the first creates the 'Move Item Failed In Client Application' error message.

Changing 'number_in_stack' to 'quantity' and disabling the iteration produces no results. I've tried changing from delete_struct
to moveitem_struct, but can't seem to get the client to take charge change commands unless the client is the originator.


I think this is another area where CSDs could be creeping in..server tells client to delete 2 charges in a 5 charge stack,
but all are deleted..and the client generates a 'Move Item Failed' error.

I don't see where normal 'actions' are causing this, but it could creep up in scripted/quest calls.

[Harakiri23]

The client has 2 different opcodes for this - one is MSG_MoveCharges to move charges from a stackable item anywhere (or delete with 0xFFFF..) and one is MSG_MoveItem - which moves non-stackable items (or delete them), can also be used to "delete" a stack of items.

The opcode names for you may differ, but that is your issue to figure out the naming in eqemu.

[image]

have you tried OP_DeleteCharge instead?