check_hasitem issue or just bad Perl Code

[Drajor]

Heya Gaflack,

I don't know much about the check_hasitem method however I thought I would suggest a slightly different approach to what you are trying to achieve. Note that I wrote this quickly and as I am no perl expert there are probably some errors!

%ITEM_RESPONSE = (
	132535, "Aviak Charm",
	132538, "Shadow Boot from the Evil Tower",
	132539, "Growler Canine",
	132540, "Knights Eye from Sebilis",
	132541, "Spiders Eye from the Velks Icy World",
	132542, "Gem of the Void from 4 Arms",
	132543, "Bugs Eye from Soldiers in the Grove",
	132544, "Western Waste Wyrm Eye",
	132545, "Undead Eye from the Umbral Skeletons",
	132546, "Valor Eye form those Cave Mobs in Valor"
);

sub EVENT_SAY {
	if ( $text=~/hail/i ) {
		foreach $i (keys (%ITEM_RESPONSE)) {
			if ( plugin::check_hasitem( $client, $i ) ) {
			$t = $ITEM_RESPONSE{$i};
			quest::say("Hail, $name! Bring me your old charm and a $t and I will upgrade your Charm");
			}
		}
	}
}

[Drajor]

So I got curious and had a look at the server side methods that are called from check_hasitem. I do not believe there is anything there which could cause the client to lock up so badly.

Also, something I failed to include in my code snippet and should also be included in your original code is a return / break after the check_hasitem has succeeded. Once you have found the item, there is no need to continue searching.