Quote:
Originally Posted by bad_captain
Secrets, is there any way you could split out the merc stuff into a separate pull request? I was looking through it last night and saw a bunch of other stuff I don't feel comfortable messing with. I'd like to be able to apply just those changes to my local machine and test them with some other changes I've made. If not, I can just apply each change manually, but I'd like to try out the pull requesy stuff. Still learning git and coming up with a more efficient process.
|
https://github.com/SecretsOTheP/Serv...4f223ee70db104 This commit has the two fixes that aren't related to mercs. You can revert them if it makes you feel more comfortable, but the rest are required to fix a few memory leaks that Derision reported.
I'm not exactly sure but I think you can just clone my repository and test the changes that way. Basically, the things I fixed are the following:
-Made emulator structure for two packets (OP_MercenaryData and OP_MercenaryMerchantResponse) static instead of creating it dynamically twice
-Fixed a memory leak in the AI code.
-Fixed a memory leak related to groups. In their current form, groups are leaking memory because they are never assigned a group ID in the unsuspend command.
-Fixed a few issues with merging groups with mercenaries in them.
-Fixed an issue where group IDs were not being handed out and leaking memory in OP_GroupDisband and OP_GroupFollow
The two changes that were not related to mercs are:
-Fixed a crash issue in the RoF encoder
-Fixed a crash issue related to calling NPC functions after the deconstructor for NPC was called.
Hybrid Mode
