SK lifetap shrouds

[Maceblade]

Mario that actually made perfect sense and fixed it! You sir are amazing! Props to you!

Whats weird tho is it only happens after lvl 37, thank you sir!

[Mariomario]

You're welcome. I'm glad I could help.

[AudioGarden21]

Clearly this is not an issue with the latest database and executables seeing as I tried to replicate this issue on my server and everything between Vampiric Embrace and Shroud of Discord functioned perfectly for me.

You must be using and older version of the database and executables. For posterity's sake, is this true?

[lerxst2112]

Well, this code is still in there:

//for some stupid reason SK procs return theirs one base off...
uint16 Mob::GetProcID(uint16 spell_id, uint8 effect_index) {
	bool sk = false;
	bool other = false;
	for(int x = 0; x < 16; x++)
	{
		if(x == 4){
			if(spells[spell_id].classes[4] < 255)
				sk = true;
		}
		else{
			if(spells[spell_id].classes[x] < 255)
				other = true;
		}
	}
	
	if(sk && !other)
	{
		return(spells[spell_id].base[effect_index] + 1);
	}
	else{
		return(spells[spell_id].base[effect_index]);
	}
}

But the sk only proc spells should be set up to account for it.

[AudioGarden21]

Yeah. I just looked at the spell file in JSRE editor and it displays 6101 spell id for Shroud of Discord instead of 6102 for the strike effect. S'pretty strange it's set up this way, or whatever would cause it to require it being set up like this.