Question about Client::SendBuffDurationPacket

[noudess]

Anyone? I could try and get the old packet sniffer out on live, but I'd much rather work on content. I guess its possible there is no packet to update only the duration?

[KLS]

You're calling it in more than guild lobby, it's also being called when you have duration inc focus. I'm not sure about the restacking effects.

[KLS]

I've tried to reproduce the stacking issue on titanium and have basically not gotten it to stack like described in GH. Using bravery I'm still at the exact same hp as when i cast it.

[noudess]

Interesting.

Strip off all your buffs. Check HP. Cast bravery. Bravery should add hp as per spell description. Here, I see it added correctly, and then the next time the function gets called, it goes up again until it hits some cap.

Perhaps you need to try with a char who's HP are not near or already capped? Try with a low level. Any buff with a slot 2 effect has this bug. If I let this code work outside the GL, spells like SoW leapfrog up and people move faster.

On my side, maybe I need to get your lastest versions of the files?

[KLS]

I sorta reproduced it but it only stacked once.

I changed the duration packet function to:

	EQApplicationPacket* outapp;
	outapp = new EQApplicationPacket(OP_Buff, sizeof(SpellBuffFade_Struct));
	SpellBuffFade_Struct* sbf = (SpellBuffFade_Struct*) outapp->pBuffer;

	sbf->entityid = GetID();
	sbf->slot = -1;
	sbf->spellid = spell_id;
	sbf->slotid = 0;
	sbf->effect = inlevel > 0 ? inlevel : GetLevel();
	sbf->level = 0;
	sbf->bufffade = 0;
	sbf->duration = duration;
	FastQueuePacket(&outapp);

Though I'm fairly certain level / effect are swapped on some clients so gotta look into that but that seemed to work for titanium.