Rev731

[blackdragonsdg]

I get a compile error in zone.exe when attempting to compile revision 731. This is the error that VS shows:

\client_packet.cpp(5579) : error C2039: 'GetMaxPetitionID' : is not a member of 'PetitionList'
d:\zeverquest\svn\source code\zone\../zone/petitions.h(97) : see declaration of 'PetitionList'

[AndMetal]

I had the same issue earlier, although I'm not really sure what caused it. I basically had to redownload zone/petitions.h manually and was able to compile.

I view & edit the source using Visual Studio C++ 2008 Express Edition, but compile it on Linux.

EDIT: It actually looks like these got taken out in Rev 729. I'm about to make a commit, so I'll get these added back in.

[blackdragonsdg]

In Rev733 the petitions.h compile error seems to be fixed but now these show up.

.\questmgr.cpp(627) : error C2572: 'QuestManager::scribespells' : redefinition of default parameter : parameter 2
d:\zeverquest\svn\source code\zone\questmgr.h(8 : see declaration of 'QuestManager::scribespells'

.\questmgr.cpp(647) : error C2572: 'QuestManager::traindiscs' : redefinition of default parameter : parameter 2
d:\zeverquest\svn\source code\zone\questmgr.h(89) : see declaration of 'QuestManager::traindiscs'

.\AA.cpp(186) : error C2664: 'void Client::Message_StringID(int32,int32,const char *,const char *,const char *,const char *,const char *,const char *,const char *,const char *,const char *,int32)' : cannot convert parameter 4 from 'uint32' to 'const char *'
Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast

.\AA.cpp(18 : error C2664: 'void Client::Message_StringID(int32,int32,const char *,const char *,const char *,const char *,const char *,const char *,const char *,const char *,const char *,int32)' : cannot convert parameter 4 from 'uint32' to 'const char *'
Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast

[realityincarnate]

Should be fixed in 734

[blackdragonsdg]

At Rev735 all is well. Thanks for the quick fixes!

[AndMetal]

Oddly enough, GCC corrects these and just throws a warning:

AA.cpp: In member function ‘void Client::ActivateAA(aaID)’:
AA.cpp:186: warning: invalid conversion from ‘uint32’ to ‘const char*’
AA.cpp:186: warning:   initializing argument 4 of ‘virtual void Client::Message_StringID(int32, int32, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, int32)’
AA.cpp:186: warning: invalid conversion from ‘uint32’ to ‘const char*’
AA.cpp:186: warning:   initializing argument 5 of ‘virtual void Client::Message_StringID(int32, int32, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, int32)’
AA.cpp:186: warning: invalid conversion from ‘uint32’ to ‘const char*’
AA.cpp:186: warning:   initializing argument 6 of ‘virtual void Client::Message_StringID(int32, int32, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, int32)’
AA.cpp:188: warning: invalid conversion from ‘uint32’ to ‘const char*’
AA.cpp:188: warning:   initializing argument 4 of ‘virtual void Client::Message_StringID(int32, int32, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, int32)’
AA.cpp:188: warning: invalid conversion from ‘uint32’ to ‘const char*’
AA.cpp:188: warning:   initializing argument 5 of ‘virtual void Client::Message_StringID(int32, int32, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, int32)’

questmgr.cpp:627: warning: default argument given for parameter 2 of ‘uint16 QuestManager::scribespells(uint8, uint8)’
questmgr.h:88: warning: after previous specification in ‘uint16 QuestManager::scribespells(uint8, uint8)’
questmgr.cpp:647: warning: default argument given for parameter 2 of ‘uint16 QuestManager::traindiscs(uint8, uint8)’
questmgr.h:89: warning: after previous specification in ‘uint16 QuestManager::traindiscs(uint8, uint8)’

But at least we got it fixed and now I know to look out for these