Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bug Reports

Development::Bug Reports Post detailed bug reports and what you would like to see next in the emu here.

Reply
 
Thread Tools Display Modes
  #1  
Old 07-01-2009, 06:29 PM
Dibalamin
Hill Giant
 
Join Date: Dec 2007
Posts: 182
Default Ahh, I feel much better now...

This seems to be missing from lifetaps...where would one go and how would one add this back to lifetap effects in the source?
__________________
Retired EMarr
Project1999 Developer
Reply With Quote
  #2  
Old 07-01-2009, 08:01 PM
AndMetal
Developer
 
Join Date: Mar 2007
Location: Ohio
Posts: 648
Default

It looks like it's in zone/attack.cpp:
Code:
			// if spell is lifetap add hp to the caster
			if (spell_id != SPELL_UNKNOWN && IsLifetapSpell( spell_id )) {
				int healed = damage;

#ifdef EQBOTS

				// Bot Liftap Heal
				if(attacker && attacker->IsBot()) {
					healed = attacker->GetBotActSpellHealing(spell_id, healed);
				}
				else

#endif //EQBOTS

				healed = attacker->GetActSpellHealing(spell_id, healed);				
				mlog(COMBAT__DAMAGE, "Applying lifetap heal of %d to %s", healed, attacker->GetName());
				attacker->HealDamage(healed);

#ifdef EQBOTS

				if(attacker->IsBot()) {
					entity_list.MessageClose(this, true, 300, MT_Spells, "%s beams a smile at %s", attacker->GetCleanName(), this->GetCleanName() );
				}
				else

#endif //EQBOTS

				//we used to do a message to the client, but its gone now.
				// emote goes with every one ... even npcs
				entity_list.MessageClose(this, true, 300, MT_Emote, "%s beams a smile at %s", attacker->GetCleanName(), this->GetCleanName() );
			}
We should be able to add something like this to the end:
Code:
entity_list.MessageClose(this, true, 300, MT_Say, "%s says 'Ahhh, I feel much better now...", attacker->GetCleanName());
We may also have to add one for the client (attacker) casting it to see "You say" instead of "Soandso says":
Code:
attacker->Message(MT_Say, "You say 'Ahhh, I feel much better now...'");
__________________
GM-Impossible of 'A work in progress'
A non-legit PEQ DB server
How to create your own non-legit server

My Contributions to the Wiki
Reply With Quote
  #3  
Old 07-09-2009, 07:13 AM
Dibalamin
Hill Giant
 
Join Date: Dec 2007
Posts: 182
Default

Works like a charm it seems, thanks!
__________________
Retired EMarr
Project1999 Developer
Reply With Quote
  #4  
Old 07-09-2009, 11:14 AM
Yeormom
Discordant
 
Join Date: Apr 2004
Location: 127.0.0.1
Posts: 402
Default

You should really just send the string id since the client already has it, which is 12117.
__________________
Yeorwned
Bane of Life [Custom Classic/PvP]
Reply With Quote
  #5  
Old 07-11-2009, 01:32 AM
AndMetal
Developer
 
Join Date: Mar 2007
Location: Ohio
Posts: 648
Default

Quote:
Originally Posted by Yeormom View Post
You should really just send the string id since the client already has it, which is 12117.
I was originally going to go that route, but it only says Ahhh, I feel much better now..., not %1 says 'Ahhh, I feel much better now...' or You say 'Ahhh, I feel much better now...'. However, if there is a way to do that, it would definitely be the better way to go.
__________________
GM-Impossible of 'A work in progress'
A non-legit PEQ DB server
How to create your own non-legit server

My Contributions to the Wiki
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 04:03 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3