Tacvi corpse dragging crashing zone

[Nibiuno]

Players are crashing the zone process when they target corpses in some areas of Tacvi. I get a message about an iterator not incrementing, and the following log file is generated:

[02-23-2015 :: 17:07:50] [Crash] EXCEPTION_BREAKPOINT
[02-23-2015 :: 17:07:50] [Crash] SymInit: Symbol-SearchPath: '.;C:\EQ\EQEmuServer;C:\EQ\EQEmuServer;C:\Windows; C:\Windows\system32;SRV*C:\websymbols*http://msdl.microsoft.com/download/symbols;', symOptions: 530, UserName: '
[02-23-2015 :: 17:07:50] [Crash] OS-Version: 6.1.7601 (Service Pack 1) 0x100-0x1
[02-23-2015 :: 17:07:50] [Crash] C:\EQ\EQEmuServer\zone.exe:zone.exe (01230000), size: 32120832 (result: 0), SymType: 'PDB', PDB: 'C:\EQ\EQEmuServer\zone.exe'
[02-23-2015 :: 17:07:50] [Crash] C:\Windows\SysWOW64\ntdll.dll:ntdll.dll (77680000), size: 1572864 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SysWOW64\ntdll.dll', fileVersion: 6.1.7601.18247
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\kernel32.dll:kernel32.dll (76FC0000), size: 1114112 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\kernel32.dll', fileVersion: 6.1.7601.18409
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\KERNELBASE.dll:KERNELBASE.dll (76BC0000), size: 290816 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\KERNELBASE.dll', fileVersion: 6.1.7601.18409
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\SHELL32.dll:SHELL32.dll (75300000), size: 12886016 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SHELL32.dll', fileVersion: 6.1.7601.18517
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\msvcrt.dll:msvcrt.dll (75F70000), size: 704512 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\msvcrt.dll', fileVersion: 7.0.7601.17744
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\SHLWAPI.dll:SHLWAPI.dll (76B50000), size: 356352 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SHLWAPI.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\GDI32.dll:GDI32.dll (764C0000), size: 589824 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\GDI32.dll', fileVersion: 6.1.7601.18577
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\USER32.dll:USER32.dll (75200000), size: 1048576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\USER32.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\ADVAPI32.dll:ADVAPI32.dll (76D40000), size: 655360 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\ADVAPI32.dll', fileVersion: 6.1.7601.18247
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\SysWOW64\sechost.dll:sechost.dll (76410000), size: 102400 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SysWOW64\sechost.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\RPCRT4.dll:RPCRT4.dll (768F0000), size: 983040 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\RPCRT4.dll', fileVersion: 6.1.7601.18532
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\SspiCli.dll:SspiCli.dll (75020000), size: 393216 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\SspiCli.dll', fileVersion: 6.1.7601.18719
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\CRYPTBASE.dll:CRYPTBASE.dll (75010000), size: 49152 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\CRYPTBASE.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\LPK.dll:LPK.dll (76BB0000), size: 40960 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\LPK.dll', fileVersion: 6.1.7601.18177
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\USP10.dll:USP10.dll (767B0000), size: 643072 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\USP10.dll', fileVersion: 1.626.7601.18454
[02-23-2015 :: 17:07:51] [Crash] C:\Perl\bin\perl512.dll:perl512.dll (28000000), size: 1273856 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\bin\perl512.dll', fileVersion: 5.12.3.1204
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18201_none_ec8 0f00e8593ece5\COMCTL32.dll:COMCTL32.dll (72D20000), size: 540672 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18201_none_ec8 0f00e8593ece5\COMCTL32.dll', fileVersion: 5.82.7601.18201
[02-23-2015 :: 17:07:51] [Crash] C:\EQ\EQEmuServer\lua51.dll:lua51.dll (605B0000), size: 356352 (result: 0), SymType: '-exported-', PDB: 'C:\EQ\EQEmuServer\lua51.dll'
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\MSVCR110.dll:MSVCR110.dll (72F20000), size: 876544 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\MSVCR110.dll', fileVersion: 11.0.51106.1
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\WS2_32.dll:WS2_32.dll (763D0000), size: 217088 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\WS2_32.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\NSI.dll:NSI.dll (77650000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\NSI.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\VERSION.dll:VERSION.dll (74C70000), size: 36864 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\VERSION.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\apphelp.dll:apphelp.dll (72DB0000), size: 311296 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\apphelp.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\AppPatch\AcLayers.DLL:AcLayers.DLL (60FC0000), size: 577536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\AppPatch\AcLayers.DLL', fileVersion: 6.1.7601.17974
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\ole32.dll:ole32.dll (75080000), size: 1425408 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\ole32.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\OLEAUT32.dll:OLEAUT32.dll (76430000), size: 585728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\OLEAUT32.dll', fileVersion: 6.1.7601.18640
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\USERENV.dll:USERENV.dll (769E0000), size: 94208 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\USERENV.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\profapi.dll:profapi.dll (75F60000), size: 45056 (result: 0), SymType: '-nosymbols-', PDB: 'C:\Windows\syswow64\profapi.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\WINSPOOL.DRV:WINSPOOL.DRV (74610000), size: 331776 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\WINSPOOL.DRV', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\MPR.dll:MPR.dll (72E00000), size: 73728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\MPR.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\IMM32.DLL:IMM32.DLL (76040000), size: 393216 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\IMM32.DLL', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\syswow64\MSCTF.dll:MSCTF.dll (771B0000), size: 835584 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\syswow64\MSCTF.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\NLAapi.dll:NLAapi.dll (74430000), size: 65536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\NLAapi.dll', fileVersion: 6.1.7601.18685
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\napinsp.dll:napinsp.dll (74420000), size: 65536 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\napinsp.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\pnrpnsp.dll:pnrpnsp.dll (74400000), size: 73728 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\pnrpnsp.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\System32\mswsock.dll:mswsock.dll (744A0000), size: 245760 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\mswsock.dll', fileVersion: 6.1.7601.18254
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\DNSAPI.dllNSAPI.dll (743B0000), size: 278528 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\DNSAPI.dll', fileVersion: 6.1.7601.17570
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\System32\winrnr.dll:winrnr.dll (743A0000), size: 32768 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\winrnr.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\rasadhlp.dll:rasadhlp.dll (742E0000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\rasadhlp.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\System32\wshtcpip.dll:wshtcpip.dll (742D0000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\wshtcpip.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Perl\lib\auto\Cwd\Cwd.dll:Cwd.dll (10000000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\Cwd\Cwd.dll'
[02-23-2015 :: 17:07:51] [Crash] C:\Perl\lib\auto\Filter\Util\Call\Call.dll:Call.dl l (000B0000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\Filter\Util\Call\Call.dll'
[02-23-2015 :: 17:07:51] [Crash] C:\Perl\lib\auto\IO\IO.dll:IO.dll (00320000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\IO\IO.dll'
[02-23-2015 :: 17:07:51] [Crash] C:\Perl\lib\auto\List\Util\Util.dll:Util.dll (00330000), size: 28672 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\List\Util\Util.dll'
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\IPHLPAPI.DLL:IPHLPAPI.DLL (74DA0000), size: 114688 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\IPHLPAPI.DLL', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\WINNSI.DLL:WINNSI.DLL (74F50000), size: 28672 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\WINNSI.DLL', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\System32\fwpuclnt.dll:fwpuclnt.dll (741E0000), size: 229376 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\fwpuclnt.dll', fileVersion: 6.1.7601.18283
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\uxtheme.dll:uxtheme.dll (72E40000), size: 524288 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\uxtheme.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\dwmapi.dll:dwmapi.dll (740F0000), size: 77824 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\dwmapi.dll', fileVersion: 6.1.7600.16385
[02-23-2015 :: 17:07:51] [Crash] C:\Windows\system32\dbghelp.dll:dbghelp.dll (60A40000), size: 962560 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\dbghelp.dll', fileVersion: 6.1.7601.17514
[02-23-2015 :: 17:07:51] [Crash] f:\dd\vctools\crt_bld\self_x86\crt\src\stdthrow.cp p (15): std::_Debug_message
[02-23-2015 :: 17:07:51] [Crash] c:\program files (x86)\microsoft visual studio 11.0\vc\include\list (230): std::_List_const_iterator<std::_List_val<std::_Lis t_simple_types<std::pair<std::basic_string<char,st d::char_traits<char>,std::allocator<char> >,unsigned short> > > >::operator++
[02-23-2015 :: 17:07:51] [Crash] c:\program files (x86)\microsoft visual studio 11.0\vc\include\list (374): std::_List_iterator<std::_List_val<std::_List_simp le_types<std::pair<std::basic_string<char,std::cha r_traits<char>,std::allocator<char> >,unsigned short> > > >::operator++
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\client.cpp (6140): Client:ragCorpses
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\client_packet.cpp (4512): Client::Handle_OP_ClientUpdate
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\client_packet.cpp (46: Client::HandlePacket
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\client_process.cpp (683): Client::Process
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\entity.cpp (472): EntityList::MobProcess
[02-23-2015 :: 17:07:51] [Crash] c:\eq\sourcerof2\zone\net.cpp (425): main
[02-23-2015 :: 17:07:51] [Crash] f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c (240): __tmainCRTStartup
[02-23-2015 :: 17:07:51] [Crash] f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c (164): mainCRTStartup
[02-23-2015 :: 17:07:51] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 76FD338A)
[02-23-2015 :: 17:07:51] [Crash] 76FD338A (kernel32): (filename not available): BaseThreadInitThunk
[02-23-2015 :: 17:07:51] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 776B9F72)
[02-23-2015 :: 17:07:51] [Crash] 776B9F72 (ntdll): (filename not available): RtlInitializeExceptionChain
[02-23-2015 :: 17:07:51] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 776B9F45)
[02-23-2015 :: 17:07:51] [Crash] 776B9F45 (ntdll): (filename not available): RtlInitializeExceptionChain

[Nibiuno]

I believe the corpses are falling under the world, and then using /tar crashes the zone.

[epilz]

yes I was having the same problem on my server and Natedog helped me on this issue. Below is what he gave me!

inside client_packet.cpp ... search for

void Client::Handle_OP_TargetCommand(const EQApplicationPacket *app)

scroll to the bottom there are 2 checks for targeting beyond the clip plane

[demonstar55]

There is nothing about targeting in the crash dump. Your line numbers are off, make sure you're running up-to-date code.

[Nibiuno]

Originally Posted by demonstar55

There is nothing about targeting in the crash dump. Your line numbers are off, make sure you're running up-to-date code.

Yeah I know, but Ive had multiple crashes, and every user mentions they were using /tar when it crashed, but the log says dragging.

It's confusing. Im updating the code again once some more fixes are in.

Thanks

[epilz]

Yes Nib, I had the same issue and once I removed the lines out of source, I stop seeing crashes

[Uleat]

I just added a safety check in Client::DraggedCorpses() to the DraggedCorpses list iteration.

Please post back if this fixes the issue.


(It looks like the targeting code might have been setting up a null mob condition and causing an issue in DraggedCorpses..I haven't followed this
through..but, a nullptr reference @ DraggedCorpses.back() would cause a list.erase() and then a ++iterator..which is UB and most likely the cause
of the EXCEPTION.)

[Nibiuno]

Thanks Uleat. Im going to do a code upgrade for Imperium today or tomorrow, as soon as I get time and will let you know.

I also have a crash when chinese players send certain chinese characters and it's interpreted by GarbleMessage in client.cpp - so I just disabled garblemessages. No big deal on that one.