Bug hunt

ksmith · #1 10-01-2003, 02:55 AM

Compare Planar Traveler's Manual (lucy) and Planar Traveler's Manual (eqemu)

There is a field between accuracy and factionmod1 that is somehow related to charm-slot items, possibly a formula id since all the ldon charms have the same value in that field.

Merth · #2 10-01-2003, 03:47 AM

Looks very likely that we have our fields off. Do you know of any items that have a value for this mysterious field?

Here's our item struct, if we shift the faction stuff down one position, remove unknown089, and add in unknown081, everything lines up.

Code:

/*080*/	sint8	Accuracy;			// PoP: Accuracy +
/*081*/	sint32	FactionMod1;		// Faction Mod 1
/*082*/	sint32	FactionMod2;		// Faction Mod 2
/*083*/	sint32	FactionMod3;		// Faction Mod 3
/*084*/	sint32	FactionMod4;		// Faction Mod 4
/*085*/	sint32	FactionAmt1;		// Faction Amt 1
/*086*/	sint32	FactionAmt2;		// Faction Amt 2
/*087*/	sint32	FactionAmt3;		// Faction Amt 3
/*088*/	sint32	FactionAmt4;		// Faction Amt 4
/*089*/	uint32	Unknown089;

Thanks for catching this, btw.

ksmith · #3 10-01-2003, 04:02 AM

Here's a listing of all the items I have where that field is non-zero:

Code:

UNK       ID          Name
=====  =====  ==================
35001   35008 - Intricate Wooden Figurine
40346   40346 - Platinum Sword Figurine
2829     41000 - Adventurer's Stone
61002   61002 - Charm of the Brotherhood
40401   67327 - Magenta Symbol
40401   67328 - Magenta Trinket
40401   67329 - Magenta Charm
40401   67330 - Magenta Amulet
40401   67331 - Magenta Talisman
40401   67332 - Crimson Symbol
40401   67333 - Crimson Trinket
40401   67334 - Crimson Charm
40401   67335 - Crimson Amulet
40401   67336 - Crimson Talisman
40401   67337 - Rustic Symbol
40401   67338 - Rustic Trinket
40401   67339 - Rustic Charm
40401   67340 - Rustic Amulet
40401   67341 - Rustic Talisman
40401   67342 - Amber Symbol
40401   67343 - Amber Trinket
40401   67344 - Amber Charm
40401   67345 - Amber Amulet
40401   67346 - Amber Talisman
40401   67347 - Azure Symbol
40401   67348 - Azure Trinket
40401   67349 - Azure Charm
40401   67350 - Azure Amulet
40401   67351 - Azure Talisman
40401   67352 - Stainless Symbol
40401   67353 - Stainless Trinket
40401   67354 - Stainless Charm
40401   67355 - Stainless Amulet
40401   67356 - Stainless Talisman
40401   67357 - Verdant Symbol
40401   67358 - Verdant Trinket
40401   67359 - Verdant Charm
40401   67360 - Verdant Amulet
40401   67361 - Verdant Talisman
40401   67362 - Ebon Symbol
40401   67363 - Ebon Trinket
40401   67364 - Ebon Charm
40401   67365 - Ebon Amulet
40401   67366 - Ebon Talisman

Merth · #4 10-01-2003, 04:45 AM

Regarding your comment about the possible connection to charms .. does the value of this column change as the power of the charm changes? Or does the value maybe relate to the type of effect?

Examples for each of the two scenarios I am talking about:

* Charm based on gold user carries, as user carries more gold, this value grows?

* Charm based on gold user carries, so value is 12345. Other charm is based on PoP flag user has, so value is 12346.

ksmith · #5 10-01-2003, 04:52 AM

The value of the field is the item id of the first item to use that charmfile. It is a static value.

flyrken · #6 10-08-2003, 02:02 PM

I think you have correctly found the "LDON ONLY" flag. It is my understanding of these charms listed that they only work (ie modify a stat) in LDON Adventures.

Nice find.

/envy

EOF

killspree · #7 10-08-2003, 02:46 PM

Nope, it's not an LDoN only flag. Quite a few of those are LoY charms - one is the charm that was introduced this summer when they made changes to what flag requirements you need in PoP.

Edit: Doing a little research - each classes Intricate Wooden Figurine uses a different item number(id field), but they all use that same unknown, 35001.

Merth · #8 10-09-2003, 01:23 AM

Made this a sticky so we don't forget to implement. This change needs to be replicated to the packet collector as well as the emu code.

ksmith · #9 10-10-2003, 06:30 AM

With the 10/09 patch, 4 new fields have been added at the end of the item data. The lore text field no longer begins with special characters to indicate lore, artifact, etc. The first of the four new fields is the lore flag (1 = lore), the remaining three are unknown to me.

Additionally, the field that used to be the last field holds some sort of augment item type restriction (0 = no restriction, 2 = Weapons only, 3= 1H Slash only)

Code:

+-------+----------------------------------+--------+
| id    | name                             | UNK102 |
+-------+----------------------------------+--------+
| 42008 | Permafrost Chunk of Resilience   |      2 |
| 42013 | Warm Emerald Shard               |      2 |
| 42018 | Freezing Flake of Pyrite         |      2 |
| 42023 | Black Diamond of Preservation    |      2 |
| 42033 | Glowing Permafrost               |      2 |
| 42038 | Enhanced Emerald of Destruction  |      3 |
| 42048 | Glowing Black Diamond            |      2 |
| 42063 | Raw Emerald Shard of Malevolence |      2 |
| 42073 | Black Diamond of Crippling       |      2 |
| 42083 | Jagged Permafrost Chunk          |      2 |
| 42098 | Rejuvenating Bone Fragment       |      2 |
| 42118 | Silver-Flecked Crystal of Agony  |      2 |
| 42123 | Blessed Black Diamond            |      2 |
| 42143 | Preserved Pyrite Crystal         |      3 |
| 42158 | Radiant Permafrost               |      2 |
+-------+----------------------------------+--------+

flyrken · #10 10-10-2003, 10:51 AM

Quote:

Originally Posted by killspree

Quite a few of those are LoY charms - one is the charm that was introduced this summer when they made changes to what flag requirements you need in PoP.

I believe a lot of the names that are on your list appear on as charms that are forsale from the Butcherblock LDON quest merchant by the GF zone line. Have those charms been packetcollected?

EOF

tbigg · #11 10-12-2003, 05:40 AM

Regarding the change to lore name and the 4 new fields:

In addition to the * symbol in the lore name that was the flag for lore items, there was also a # symbol for items that are artifacts. The # could appear in either the 1st or 2nd position, depending on whether the item was also flagged as lore. Do an item search with Artifact = Yes to see this.

So I would guess that one of the 4 new fields is a flag for artifact items

ksmith · #12 10-21-2003, 04:57 AM

As pointed out by ric0h, elemdmgtype and elemdmgamt are reversed in the database.

ric0h · #13 10-21-2003, 05:26 AM

Could you also please change the way nodrop and norent fields and make them like loreflag and artifactflag? E.g. loreflag=1|0 ?
That'll make the table much more easier to read.

Merth · #14 10-21-2003, 08:29 AM

Quote:

Could you also please change the way nodrop and norent fields and make them like loreflag and artifactflag? E.g. loreflag=1|0 ?
That'll make the table much more easier to read.

Not sure I follow you here. You want us to transform values between database and network code? Although it would look nice in the db, it has too much potential for problems down the road. What you see coming across the wire is what you see in the item db.

ric0h · #15 10-21-2003, 10:05 AM

ok then what is the meaning of value 255 for nodrop and norent fields and what other values they might have?