I need to fix this folks

[lerxst2112]

Originally Posted by Uleat

Do we need to change this to double from float and add a con check for '(base*mod) > ~0'?

Why? There shouldn't be an issue with range or precision using a float.

[Uleat]

Nope, you're right...

x = 3000000000, y = 3E+09, z = 3000000000

x as uint32 = 3,000,000,000
y as single = x
z as uint32 = y


I'm just not seeing where a conversion issue is occurring in the above procedure...

[lerxst2112]

It isn't there, it's somewhere else the value is being used.

Here's an example from Client::Death()

	// now we apply the exp loss, unmem their spells, and make a corpse
	// unless they're a GM (or less than lvl 10
	if(!GetGM())
	{
		if(exploss > 0) {
			int32 newexp = GetEXP();
			if(exploss > newexp) {
				//lost more than we have... wtf..
				newexp = 1;
			} else {
				newexp -= exploss;
			}
			SetEXP(newexp, GetAAXP());
			//m_epp.perAA = 0;	//reset to no AA exp on death.
		}

There may be more that are less obvious. Some of the rez and sacrifice code is suspect, but I'm too lazy to do the math.

[Drajor]

My source is a few weeks out of date but in Client::SetLevel the return value of GetEXPForLevel is being cast as a float numerous times. That would do it. Change float to double.

float tmpxp = (float) ( (float) m_pp.exp - GetEXPForLevel( GetLevel() )) /
( (float) GetEXPForLevel(GetLevel()+1) - GetEXPForLevel(GetLevel()));
lu->exp = (uint32)(330.0f * tmpxp);

Holy sh*t wut!?

[Drajor]

Ugh I just realised exp is stored cumulatively..

[lerxst2112]

Float is probably ok there too. Without extracting that out into a test to see what the numbers are I'd guess you might lose a very small bit of precision, but a float isn't going to roll over to a negative number like a signed int would. Besides, that formula is just to tell the client how far to fill up the experience bar. If it was incorrect the server would still have the proper value and you'd level when you didn't expect it.

[Armm]

Try what i posted here... Works for me..

http://www.eqemulator.org/forums/sho...466#post219466