Just to play devil's advocate...
Since there have been plenty of complaints about code NOT making it CVS....
I've had my hands in a handful of open-source projects in the past, even was founder/lead developer on a couple (admittedly, insignificant) ones. But one lesson I learned fast - that I'm sure the devs here deal with - is a matter of coding style. Plenty of people can patch broken code, but maybe not in a way that is consistent with the remainder of the code. This can, depending on the severity of the deviation, have effects ranging from breaking other features down the pipe (or making them impossible to implement effectively) to just making the code appreciably more difficult to read and work with in the future.
Incidentally, I would think this would be one of the bigger reasons code snippets are to be posted, rather than providing .diff files to modify the head directly. And if it takes the devs time to read through the various submissions, and yet more time to adjust the coding style of the fragment and update the CVS head (giving the benefit of the doubt, and assuming the code is decent enough to at least be implementable at an algorithmic level), then I'm all for it - give them as much time as they feel they need to do the job right the first time.
Nothing is worse than a fast or short-sighted fix (and perhaps short-sighted only by not knowing what the dev team has in store for the future) that just breaks more code down the road. Better, I say, if the CVS updates are less frequent as they have been, but of higher integrity.
Just my two cents, from a development standpoint.
|