auto-train on level for the extra lazy

[atrayas]

Im having trouble getting this to work. We had it working fine before but we just recently migrated our server from a windows 7 baed machine to a Linux machine running debian8. Below is a copy of the perl script we are using, that worked fine before we migrated.

sub AutoTrain {

    $client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );

    # set all available skills to maximum for race/class at current level
    foreach my $skill ( 0 .. 42 ) {
        next unless $client->CanHaveSkill($skill);
        my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
        next unless $maxSkill > $client->GetRawSkill($skill);
        $client->SetSkill( $skill, $maxSkill );
    }
	foreach my $skill ( 48 .. 55 ) {
        next unless $client->CanHaveSkill($skill);
        my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
        next unless $maxSkill > $client->GetRawSkill($skill);
        $client->SetSkill( $skill, $maxSkill );
    }
	foreach my $skill ( 66 .. 73 ) {
        next unless $client->CanHaveSkill($skill);
        my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
        next unless $maxSkill > $client->GetRawSkill($skill);
        $client->SetSkill( $skill, $maxSkill );
    }
    # scribe all spells for current level
    quest::scribespells( $ulevel, $ulevel - 1 );

    # train all discs for current level
    quest::traindiscs( $ulevel, $ulevel - 1 );

}

[tearinall]

Haven't tested it for functionality, don't see anything immediately wrong besides unneeded lines:

sub AutoTrain {
    $client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );
    # set all available skills to maximum for race/class at current level
    foreach my $skill (0..42,48..55,66..73) {
        if ($client->CanHaveSkill($skill)) {
			my $maxSkill = $client->MaxSkill($skill);
			if ($maxSkill > $client->GetRawSkill($skill)) {
				$client->SetSkill($skill, $maxSkill );
			}
		}
	}
    # scribe all spells for current level
    quest::scribespells( $ulevel, $ulevel - 1 );
    # train all discs for current level
    quest::traindiscs( $ulevel, $ulevel - 1 );
}

Bah, copied from the wrong tab.

[atrayas]

The only thing I can figure is something minuscule was altered during the transfer from windows to linux but I cant quite figure out what it could be. Like we had a few issues with perl scripts with the names in lowercase and Linux being case sensitive.

[Azrealvect]

Also note that if you go from skills 66-73 you will get a few trade skills in there. Think its JC and and Pottery if I remember right. Just a thought though as I see you skipped the others.

[Jahosphat]

Originally Posted by NatedogEZ

Try this... (might want to test it.. lol I r bad at lua)


This will train all skills except tradeskills

function event_level_up(e)
	local skills = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 48, 49, 50, 51, 52, 53, 54, 56, 62, 66, 67, 70, 71, 72, 73, 74 };
	for i, curskill in ipairs(skills) do
		local maxskill = e.self:MaxSkill(curskill);
		if (e.self:CanHaveSkill(curskill) == false) then
			--Do nothing...
		elseif (maxskill <= e.self:GetRawSkill(curskill)) then
			--Do nothing...
		else
			--Train!
			e.self:SetSkill(curskill, maxskill);
		end
	end
end

Do i just add this and replace the other level event in global.lua? Also can you add Spells / Disc to this code?

[jpyou127]

Would anyone that is versed in LUA be able to create the above with spell scribe and discs?

Ex from above.

If anyone is interested this will train everything but trade skills and spell specializations.

Code:
sub EVENT_LEVEL_UP {

AutoTrain();

}

sub AutoTrain {

$client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );

# set all available skills to maximum for race/class at current level
foreach my $skill ( 0 .. 42, 48 .. 54, 70 .. 74 ) {
next unless $client->CanHaveSkill($skill);
my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
next unless $maxSkill > $client->GetRawSkill($skill);
$client->SetSkill( $skill, $maxSkill );
}

# scribe all spells for current level
quest::scribespells( $ulevel, $ulevel - 1 );

# train all discs for current level
quest::traindiscs( $ulevel, $ulevel - 1 );

}

[Ninlin]

Originally Posted by jpyou127

Would anyone that is versed in LUA be able to create the above with spell scribe and discs?

Ex from above.

I think this is what you requested? You can toy with it a bit the change the level granted etc. We dropped a couple extra NPC into PoK and put these in lua quest files for them. You could add them to MisterLockout or the like. Also, my original code (not here) has some additions for things like clearing out a spellbook or discs before scribing all the new ones or for restricting lists of spells. Happy to provide that if you like, but figured I'd give minimal working example. (I also just allow the NPC to scribe/train everything up to current level, so I omit the second argument in the scribspells function for our server.)

-- #Spell_Scribe
-- Used to allow players to scribe all spells at an NPC.

function event_say(e)

	if(e.message:findi("hail")) then
		-- Intro message
		e.other:Message(257, "Hail, adventurer! I can teach you all your spells! Would you like me to [" ..eq.say_link('write them', false, 'write them') .."] down for you in that book?")

	elseif(e.message:findi("write them")) then

		-- scribe all spells for current level
		e.other:scribe_spells(e.other:GetLevel(), e.other:GetLevel()-1);

	end

end

-- #Discipline_Trainer
-- Used to allow players to train disciplines at an NPC.

function event_say(e)

	if(e.message:findi("hail")) then
		-- Intro message
		e.other:Message(257, "Would you prefer that I ["..eq.say_link('teach', false, 'teach') .. "] you how to perform the skills that require more discipline than the basics?")

	elseif(e.message:findi("teach")) then

		-- scribe all disciplines for level
		eq.train_discs(e.other:GetLevel(), e.other:GetLevel()-1);

	end


end

[Baelu]

Sorry to necro the thread, but if I wanted this to stop at say level 70, would it look like this?

sub AutoTrain {

    if ($ulevel <= 70) {
	$client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );

    # set all available skills to maximum for race/class at current level
    foreach my $skill ( 0 .. 74 ) {
        next unless $client->CanHaveSkill($skill);
        my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
        next unless $maxSkill > $client->GetRawSkill($skill);
        $client->SetSkill( $skill, $maxSkill );
    }

    # scribe all spells for current level
    quest::scribespells( $ulevel, $ulevel - 1 );

    # train all discs for current level
    quest::traindiscs( $ulevel, $ulevel - 1 );

}
}
}

[Baelu]

Tested and works perfect

[ghanja]

You have an extra curly in the code above.

sub AutoTrain {
    if ($ulevel <= 70) {
		$client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );
		# set all available skills to maximum for race/class at current level
		foreach my $skill ( 0 .. 74 ) {
			next unless $client->CanHaveSkill($skill);
			my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
			next unless $maxSkill > $client->GetRawSkill($skill);
			$client->SetSkill( $skill, $maxSkill );
		}
		# scribe all spells for current level
		quest::scribespells( $ulevel, $ulevel - 1 );
		# train all discs for current level
		quest::traindiscs( $ulevel, $ulevel - 1 );
	}
}

For it to apply to only level 2-70.

May as well just put it in the sub EVENT_LEVEL_UP like so:

sub EVENT_LEVEL_UP {
    if ($ulevel <= 70) {
		$client->Message( 15, "Your experiences across the realm have infused you with increased power and knowledge..." );
		# set all available skills to maximum for race/class at current level
		foreach my $skill ( 0 .. 74 ) {
			next unless $client->CanHaveSkill($skill);
			my $maxSkill = $client->MaxSkill( $skill, $client->GetClass(), $ulevel );
			next unless $maxSkill > $client->GetRawSkill($skill);
			$client->SetSkill( $skill, $maxSkill );
		}
		# scribe all spells for current level
		quest::scribespells( $ulevel, $ulevel - 1 );
		# train all discs for current level
		quest::traindiscs( $ulevel, $ulevel - 1 );
	}
}

Unless you intend to make it it's own subroutine of course.

[ghanja]

Also, since this thread had a lot of conversation. The iteration you have does all skills 0 through 74. That will include trade skills and such. Use this as a reference as to which skills you actually want to have affected or at least confirm:

http://wiki.eqemulator.org/p?Skills

[Baelu]

Awesome was just thinking about that haha. Thanks man

[Shin Noir]

When I tackled this, I ended up editing source and just went into
Client::SetLevel around the point it calls DoTributeUpdate(), I declared a new function called Client::UpdateSkillsAndSpells().

The scripted way is probably easier, but with this route, you get nearly full control of what a player autotrains. This may be useful in cases where you don't want *all* spells memorized automatically, yet certain spells can be obtained via quests/other means while other baseline ones are obtained.

Then I just tossed this into the UpdateSkillsAndSpells() call.
https://gist.github.com/xackery/a7ba...5eda7e37596ae1

Note this does not max skills, but really just sharing it for those who stumble upon this post to see another way. *shrugs*

This gives me granular control over what skills and spells a player earns on levelup.
You'll see a javascript selector snippet in the source, like so:

for ($i = 0; $i < document.querySelectorAll('a').length; $i++) { $ref = document.querySelectorAll('a')[$i].href; if ($ref.includes("zstrat")) { console.log($ref); } }

I leveraged this to hit up http://everquest.allakhazam.com/db/s...&action=search
Change your class, in chrome, right click the page and go to Inspect, then the Console tab, then click the circle with a line through to clear console, and paste in the above selector. Then right right click the listed output, hit Save As...and it'll create a logfile dump with the info.

Open it in a multiline edit tool like Sublime or TextWrangler and manipulate it into a conditional list, and remove any spells you don't want.

[hayward6]

So this is working perfectly for giving skills to players, what's the best way to provide spell scribing in here? I want it to just happen at skill-up. I chopped up what was posted earlier in an npc and I couldn't get it working. I understand lua is probably great, but I had a hard enough time with perl

function event_level_up(e)
	local skills = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 48, 49, 50, 51, 52, 53, 54, 56, 62, 66, 67, 70, 71, 72, 73, 74 };
	for i, curskill in ipairs(skills) do
		local maxskill = e.self:MaxSkill(curskill);
		if (e.self:CanHaveSkill(curskill) == false) then
			--Do nothing...
		elseif (maxskill <= e.self:GetRawSkill(curskill)) then
			--Do nothing...
		else
			--Train!
			e.self:SetSkill(curskill, maxskill);
		end
	end
end

[macdaddy02]

I'm not sure if this is old or I should post here anymore, however I got a .lua code that works and thought I'd share it with everyone.

function event_level_up(e)
		e.self:Message(15, "You have gained the knowledge of learning new skills, spells and discs!!");
	local skills = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 48, 49, 50, 51, 52, 53, 54, 56, 62, 66, 67, 70, 71, 72, 73, 74 };
	for i, curskill in ipairs(skills) do
		local maxskill = e.self:MaxSkill(curskill);
		if (e.self:CanHaveSkill(curskill) == false) then
			--Do nothing...
		elseif (maxskill <= e.self:GetRawSkill(curskill)) then
			--Do nothing...
		else
		    -- Scribe all spells up to current level
		   eq.scribe_spells(e.self:GetLevel());
                   -- Train all disciplines up to current level
                   eq.train_discs(e.self:GetLevel());
	           --Train all skills for current level
		   e.self:SetSkill(curskill, maxskill);
		end
	end
end